lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

feat(generative): POST /concepts/recompute — live финрасчёт по massing-program (#1965 Stage 2a) #2024

Merged
bot-backend merged 3 commits from feat/concept-recompute-1965-stage2a into main 2026-06-27 19:53:54 +00:00
Conversation 0 Commits 3 Files changed 6 +621 -2
bot-backend commented 2026-06-27 19:34:52 +00:00
Collaborator
Copy link

#1965 Stage 2a (эпик #1953) — backend для живого пересчёта экономики от интерактивного 3D. code-reviewer ✅ APPROVE. Бэкенд-онли, без миграций, аддитивно.

Что

  • synthesize_teap_from_program(total_footprint_sqm, floors, site_area_sqm, housing_class, sections=1) (teap.py) — чистая: built=footprint, GFA=footprint×floors, те же константы share/efficiency что у synthesize_teap_from_buildability/compute_teap (drift невозможен; parity-тест = byte-equal TEAP с compute_teap на эквивалентном прямоугольнике).
  • Схемы MassingProgram + MassingRecomputeOutput (Literal-наборы точно как у ConceptInput/compute_financial).
  • POST /api/v1/concepts/recompute → synthesize_teap_from_program → существующий compute_financial → TEAP+FinancialModel.
  • Резолв цены (приоритет): body market_price_per_sqm (FAST, без БД) → _lookup_market_price (threadpool, если есть parcel_centroid_wkt) → class_norm. price_source пробрасывается (честный флаг происхождения цены — не мислейблит).

Безопасность

  • mypy-strict (generative) чисто; ruff ✅; no :name::type; 125 passed (+ 12 новых: gfa-математика, parity, class-efficiency, price passthrough/fallback, bounds 1-40/1-6, exploding-session доказывает no-DB на fast-path).
  • compute_financial НЕ тронут (чистая функция, in-loop — без БД/IO). Аддитивный endpoint+схемы → консьюмеров нет (Stage 2b — следующий).

Stage 2b (следующий PR): 3D MassingScene в секцию «7. Концепция» + debounced-хук на этот endpoint → живой пересчёт NPV/IRR при кручении этажности/секций. Refs #1965.

#1965 Stage 2a (эпик #1953) — backend для живого пересчёта экономики от интерактивного 3D. code-reviewer ✅ APPROVE. Бэкенд-онли, без миграций, аддитивно. ## Что - `synthesize_teap_from_program(total_footprint_sqm, floors, site_area_sqm, housing_class, sections=1)` (teap.py) — чистая: built=footprint, GFA=footprint×floors, **те же** константы share/efficiency что у `synthesize_teap_from_buildability`/`compute_teap` (drift невозможен; parity-тест = byte-equal TEAP с compute_teap на эквивалентном прямоугольнике). - Схемы `MassingProgram` + `MassingRecomputeOutput` (Literal-наборы точно как у ConceptInput/compute_financial). - `POST /api/v1/concepts/recompute` → synthesize_teap_from_program → **существующий `compute_financial`** → TEAP+FinancialModel. - **Резолв цены (приоритет):** body `market_price_per_sqm` (FAST, без БД) → `_lookup_market_price` (threadpool, если есть `parcel_centroid_wkt`) → class_norm. `price_source` пробрасывается (честный флаг происхождения цены — не мислейблит). ## Безопасность - mypy-strict (generative) чисто; ruff ✅; no `:name::type`; **125 passed** (+ 12 новых: gfa-математика, parity, class-efficiency, price passthrough/fallback, bounds 1-40/1-6, exploding-session доказывает no-DB на fast-path). - compute_financial НЕ тронут (чистая функция, in-loop — без БД/IO). Аддитивный endpoint+схемы → консьюмеров нет (Stage 2b — следующий). Stage 2b (следующий PR): 3D `MassingScene` в секцию «7. Концепция» + debounced-хук на этот endpoint → живой пересчёт NPV/IRR при кручении этажности/секций. Refs #1965.
bot-backend added 2 commits 2026-06-27 19:34:52 +00:00 
Stage 2a of epic #1953: backend service + endpoint for live economic recompute
driven by the interactive 3D massing (Stage 2b debounced sliders).

- teap.py: add pure synthesize_teap_from_program(total_footprint_sqm, floors,
  site_area_sqm, housing_class, sections) — builds a TEAP from the SCALAR
  aggregate footprint × floors, mirroring synthesize_teap_from_buildability and
  reusing the same shared norm constants (_OFFICE_SHARE_OF_GFA / _EFFICIENCY_BY_CLASS
  / _AVG_APARTMENT_SQM / _PARKING_PER_APARTMENT) — single source of truth.
- schemas/concept.py: add MassingProgram (program contract, optional pre-resolved
  market_price_per_sqm + parcel_centroid_wkt) and MassingRecomputeOutput (teap + financial).
- api/v1/concepts.py: add POST /api/v1/concepts/recompute — synthesize TEAP → run
  the existing pure compute_financial. FAST path uses body market_price_per_sqm
  (no DB); else _lookup_market_price by centroid via run_in_threadpool; else class norm.
- tests: synthesize_teap_from_program (gfa math, parity with compute_teap, class
  efficiency, sections no-op) + endpoint (200, coherent output, price passthrough
  skips DB, DB fallback, class-norm default, floors validation).
fix(generative): forward genuine price_source through /recompute (#1965 Stage 2a)
Some checks failed
CI / frontend-tests (pull_request) Has been skipped
Details
CI / changes (pull_request) Successful in 7s
Details
CI / openapi-codegen-check (pull_request) Failing after 1m49s
Details
CI / backend-tests (pull_request) Successful in 13m49s
Details
18d012da1b 
Code-review follow-up: /recompute hardcoded price_source="objective_district_median"
for any body-supplied market_price_per_sqm, mislabeling the honesty-flag once
Stage 2b forwards a price whose genuine source differs (objective_geo_radius /
district_reference / class_norm from financial_estimate).

- schemas/concept.py: add optional price_source: str | None to MassingProgram.
- api/v1/concepts.py: on FAST path use payload.price_source if provided, else the
  default label (now a module-level constant _DEFAULT_PRERESOLVED_SOURCE). DB-fallback
  and class-norm paths keep their own resolved source unchanged.
- tests: assert body-provided price_source echoes through to financial.price_source
  (not overwritten), and the default label applies when the front omits it.
Light1YT added 1 commit 2026-06-27 19:39:07 +00:00
chore(frontend): regenerate api-types.ts for /concepts/recompute (#1965 Stage 2a)
All checks were successful
CI / changes (pull_request) Successful in 8s
Details
CI / frontend-tests (pull_request) Successful in 1m17s
Details
CI / openapi-codegen-check (pull_request) Successful in 2m11s
Details
CI / backend-tests (pull_request) Successful in 14m1s
Details
7e824ce6e4 
The new POST /api/v1/concepts/recompute endpoint + MassingProgram /
MassingRecomputeOutput schemas changed the backend OpenAPI; the generated
frontend/src/lib/api-types.ts was out of sync, failing the CI
openapi-codegen-check gate. Regenerated via the exact CI sequence
(openapi-typescript + prettier 3.9.0). Byte-stable on 2nd regen; tsc --noEmit clean.
bot-backend merged commit 01b0dc74de into main 2026-06-27 19:53:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#2024
No description provided.
Delete branch "feat/concept-recompute-1965-stage2a"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?