fix(leads): replace ::interval cast with make_interval (psycopg v3 trap) (#1383 follow-up) #1707
No reviewers
Labels
No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lekss361/gendesign#1707
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "fix/admin-leads-interval-cast-1694"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Проблема (ревью #1694)
admin_leads.py:141и 5 идентичных мест вanalytics_queries.py(функции, вызываемые из admin_leads-роутов) использовали(:m || ' months')::interval— psycopg v3 CAST trap (:x::typeзапрещён правилом проекта).Решение
6 случаев →
make_interval(months => :m)(чище чемCAST(... AS interval)). Логика окон сохранена.Verify
ruffclean;pytest -k "lead or admin_lead"→ 4 passed, 1 skipped; live-DB sanitymake_interval(months => 12)ok.NB: фикс атомарный — 2 файла в одном коммите (6 трапов в функциях одного роута).