fix(leads): window revenue_total/deals_total to leads_window (#1383) #1694

Merged

lekss361 merged 1 commit from fix/leads-stats-window-1383 into main

2026-06-17 18:05:53 +00:00

lekss361 commented

2026-06-17 17:56:51 +00:00

Owner

Проблема (#1383, LOW)

admin_leads.py:152: revenue_total/deals_total считались за всё время, а остальная статистика — за leads_window → revenue/deals не соответствовали окну «за период».

Решение

revenue/deals скоупятся по window_leads.deal_id (сделки, привязанные к лидам с created_at в окне NOW()-N мес). leads_total/sources_total намеренно остаются all-time (измеряют всю базу, консистентно имени). window_months уже в ответе.

Verify

ruff clean, AST ok; pytest -k "lead or admin_lead" → 4 passed, 1 skipped.

Closes #1383

## Проблема (#1383, LOW) `admin_leads.py:152`: `revenue_total`/`deals_total` считались за всё время, а остальная статистика — за `leads_window` → revenue/deals не соответствовали окну «за период». ## Решение revenue/deals скоупятся по `window_leads.deal_id` (сделки, привязанные к лидам с `created_at` в окне `NOW()-N мес`). `leads_total`/`sources_total` намеренно остаются all-time (измеряют всю базу, консистентно имени). `window_months` уже в ответе. ## Verify `ruff` clean, AST ok; `pytest -k "lead or admin_lead"` → **4 passed, 1 skipped**. Closes #1383

lekss361 added 1 commit 2026-06-17 17:56:52 +00:00

fix(leads): window revenue_total/deals_total to leads_window (#1383 )

CI / changes (push) Successful in 10s

Details

CI / changes (pull_request) Successful in 8s

Details

CI / frontend-tests (push) Has been skipped

Details

CI / openapi-codegen-check (push) Successful in 1m42s

Details

CI / frontend-tests (pull_request) Has been skipped

Details

CI / openapi-codegen-check (pull_request) Successful in 1m45s

Details

CI / backend-tests (push) Failing after 8m48s

Details

CI / backend-tests (pull_request) Failing after 8m46s

Details

64ed95271f

Both metrics were querying prinzip_deals without any date filter,
returning all-time figures while the surrounding stats (leads_window,
converted_window, conv_pct_window) were scoped to the last N months.
Now both subqueries restrict to deals linked to leads in window_leads
(via deal_id IN (...)), making all «за период» figures consistent.