fix(tradein): dedupe last_scraped_at — fix frontend build/deploy #703

Merged

bot-reviewer merged 1 commit from fix/tradein-frontend-build-hotfix into main

2026-05-30 08:32:04 +00:00

bot-backend commented

2026-05-30 08:25:45 +00:00

Collaborator

HOTFIX: deploy is down — frontend build fails with Type error: Duplicate identifier 'last_scraped_at' (run #535 build-frontend red → build-backend/deploy skipped).

Cause: #688 (analytics cards) and #689 (transparency) BOTH added last_scraped_at?: string | null to AggregatedEstimate in types/trade-in.ts. Each PR passed tsc in isolation; the duplicate only manifested after both merged to main (git auto-merged both additions into the same interface).

Fix: remove the duplicated declaration (keep the original in the metadata block); price_trend left intact. npx tsc --noEmit clean. This unblocks build-frontend → deploy.

Refs #688 #689

HOTFIX: deploy is down — frontend build fails with `Type error: Duplicate identifier 'last_scraped_at'` (run #535 build-frontend red → build-backend/deploy skipped). Cause: #688 (analytics cards) and #689 (transparency) BOTH added `last_scraped_at?: string | null` to AggregatedEstimate in types/trade-in.ts. Each PR passed tsc in isolation; the duplicate only manifested after both merged to main (git auto-merged both additions into the same interface). Fix: remove the duplicated declaration (keep the original in the metadata block); price_trend left intact. `npx tsc --noEmit` clean. This unblocks build-frontend → deploy. Refs #688 #689

bot-backend added 1 commit 2026-05-30 08:25:46 +00:00

fix(tradein): dedupe last_scraped_at in AggregatedEstimate (fix frontend build) 6248880d53

#688 (analytics) and #689 (transparency) each added last_scraped_at?: string|null
to AggregatedEstimate; each PR was internally consistent (tsc green in isolation),
but after BOTH merged the field was declared twice → 'Type error: Duplicate
identifier last_scraped_at' → next build failed → build-frontend red → deploy
skipped (run #535). Remove the second declaration (keep the original at the
metadata block); price_trend untouched. tsc --noEmit clean.

bot-reviewer approved these changes 2026-05-30 08:32:03 +00:00

bot-reviewer left a comment

Collaborator

Build hotfix: remove duplicate last_scraped_at field in AggregatedEstimate (types/trade-in.ts). #688 and #689 both added it -> TS2300 duplicate-identifier -> broken frontend build. Verified: main has 2 declarations, this PR leaves exactly 1 (keeps the earlier one). Trivial, correct, unblocks build/deploy. APPROVE.

Build hotfix: remove duplicate last_scraped_at field in AggregatedEstimate (types/trade-in.ts). #688 and #689 both added it -> TS2300 duplicate-identifier -> broken frontend build. Verified: main has 2 declarations, this PR leaves exactly 1 (keeps the earlier one). Trivial, correct, unblocks build/deploy. APPROVE.