feat(tradein): configurable estimate quota + new exhausted-quota copy (#658) #671

Merged

bot-reviewer merged 1 commit from feat/tradein-658-limit into main

2026-05-29 16:07:03 +00:00

bot-backend commented

2026-05-29 15:48:02 +00:00

Collaborator

Make the monthly estimate quota limit configurable via Settings.estimate_quota_limit (env ESTIMATE_QUOTA_LIMIT, default 15), replacing the hardcoded 15 in account_quota.py.

Change the exhausted-quota text (backend 429 detail + frontend banner) to 'За полной версией обращайтесь к Копылову'; banner now renders the dynamic limit value.

core/config.py: estimate_quota_limit=15 (env ESTIMATE_QUOTA_LIMIT)
services/account_quota.py: MONTHLY_LIMIT from settings; new 429 text
frontend EstimateForm.tsx: dynamic limit + new banner text
tests/test_account_quota.py updated (28 pass); ruff clean; grep confirms no old text remains

Milestone 6 (Praktika demo). Closes #658

Make the monthly estimate quota limit configurable via Settings.estimate_quota_limit (env ESTIMATE_QUOTA_LIMIT, default 15), replacing the hardcoded 15 in account_quota.py. Change the exhausted-quota text (backend 429 detail + frontend banner) to 'За полной версией обращайтесь к Копылову'; banner now renders the dynamic limit value. - core/config.py: estimate_quota_limit=15 (env ESTIMATE_QUOTA_LIMIT) - services/account_quota.py: MONTHLY_LIMIT from settings; new 429 text - frontend EstimateForm.tsx: dynamic limit + new banner text - tests/test_account_quota.py updated (28 pass); ruff clean; grep confirms no old text remains Milestone 6 (Praktika demo). Closes #658

bot-backend added 1 commit 2026-05-29 15:48:03 +00:00

feat(tradein): configurable estimate quota + new exhausted-quota copy (#658 ) 8472d83ac3

Make the monthly estimate quota limit configurable via
Settings.estimate_quota_limit (env ESTIMATE_QUOTA_LIMIT, default 15),
replacing the hardcoded 15 in account_quota.py. Change exhausted-quota
text (backend 429 detail + frontend banner) to
'За полной версией обращайтесь к Копылову'; banner uses dynamic limit.

Closes #658

bot-reviewer approved these changes 2026-05-29 16:07:02 +00:00

bot-reviewer left a comment

Collaborator

Parameterizes hardcoded monthly quota 15 -> settings.estimate_quota_limit (env ESTIMATE_QUOTA_LIMIT, default 15) + new exhausted copy (#658). Verified: frontend limit is a pre-existing prop (limit?: number|null), {limit ?? 15} valid (no TS break); counter already uses dynamic limit from /quota API; message+test updated consistently. Import-time MONTHLY_LIMIT capture OK for env-set-at-startup. Consistent with vault Module_TradeIn_Account_Quota (PR #635), no regression. APPROVE.

Parameterizes hardcoded monthly quota 15 -> settings.estimate_quota_limit (env ESTIMATE_QUOTA_LIMIT, default 15) + new exhausted copy (#658). Verified: frontend limit is a pre-existing prop (limit?: number|null), {limit ?? 15} valid (no TS break); counter already uses dynamic limit from /quota API; message+test updated consistently. Import-time MONTHLY_LIMIT capture OK for env-set-at-startup. Consistent with vault Module_TradeIn_Account_Quota (PR #635), no regression. APPROVE.