lekss361/gendesign

Fork 0

feat(tradein-ui): Cian cookies upload admin page #481

Merged

lekss361 merged 3 commits from feat/tradein-cian-cookies-ui into main

2026-05-23 15:19:43 +00:00

lekss361 commented

2026-05-23 14:49:25 +00:00

Owner

Summary

Admin UI page для upload Cian Valuation Calculator cookies — paste JSON → POST /api/v1/admin/scrape/cian/upload-cookies (Stage 4 backend endpoint).

Files

frontend/src/app/admin/scrape/cian-cookies/page.tsx (NEW, 462 lines)
frontend/src/app/admin/layout.tsx (+1 line — tab entry)

URL

/admin/scrape/cian-cookies

Features

Format auto-detection (client-side)

Paste может быть в одном из 2 форматов:

Cookie-Editor extension (массив объектов):

[{"domain": ".cian.ru", "name": "DMIR_AUTH", "value": "xxx", ...}, ...]

Simple dict (после ручной конвертации):
```
{"DMIR_AUTH": "xxx", "_CIAN_GK": "yyy", ...}
```

Page detects format и converts to dict client-side. Preview "Detected N cookies: name1, name2, ..." обновляется на каждый keystroke (pure synchronous parse).

Upload flow

Paste JSON в textarea (rows=15, monospace)
Live preview shows detected cookie count
Click "Upload" → POST /api/v1/admin/scrape/cian/upload-cookies
Response: {ok: true, userId: ..., cookieCount: ...} (success) или error message
Backend verifies через /kalkulator-nedvizhimosti/ (auth check) → encrypt → DB

Test current session

Separate button "Test Auth" → GET /api/v1/admin/scrape/cian/test-auth
Returns: {authenticated: true, userId: ...} или {authenticated: false, reason: ...}

useQuery with enabled: false + .refetch() — manual trigger, no auto-fetch on mount.

Patterns reused

Auth: localStorage.getItem("admin_token") + X-Admin-Token header (same as /admin/scrape/page.tsx)
Styling: cardStyle/inputStyle/labelStyle from @/lib/adminStyles
API: apiFetch from @/lib/api
TanStack Query useMutation для POST, useQuery (enabled:false) для on-demand GET

TS strict

Record<string, string> для cookie dict
UploadResponse / TestAuthResponse interfaces
No any types
Coerce values to String(v) в conversion (handles numeric / boolean values)

Security

No dangerouslySetInnerHTML (JSON stays в textarea value)
Admin token из localStorage (existing project pattern)
Cookies marked sensitive — UI clears textarea на successful upload (optional — TBD UX preference)

Push verify

LOCAL == REMOTE = b92eb81f

Decisions

Path is /admin/scrape/cian-cookies (not /trade-in/admin/...) — no (trade-in) route group exists; admin pages live under /admin/scrape/
useQuery with enabled: false for test-auth — cleaner than useMutation для GET, avoids auto-fetch anti-pattern
uploadMutation.reset() on textarea change — clears stale success/error banners

Refs

PR #457 (Stage 4 — backend endpoints + scripts/upload-cian-cookies.sh)
PR #465 (Stage 7 — cian_valuation.py uses uploaded session)
Sibling fix PR (feat/tradein-cian-cookies-real-list) — fixes backend filter list

Test plan

TS strict compile clean
Page renders без runtime errors
Post-deploy: paste Cookie-Editor JSON → preview detects N cookies → upload returns 200 + userId
Test Auth button shows current session state

## Summary Admin UI page для upload Cian Valuation Calculator cookies — paste JSON → POST `/api/v1/admin/scrape/cian/upload-cookies` (Stage 4 backend endpoint). ## Files - `frontend/src/app/admin/scrape/cian-cookies/page.tsx` (NEW, 462 lines) - `frontend/src/app/admin/layout.tsx` (+1 line — tab entry) ## URL `/admin/scrape/cian-cookies` ## Features ### Format auto-detection (client-side) Paste может быть в одном из 2 форматов: 1. **Cookie-Editor extension** (массив объектов): ```json [{"domain": ".cian.ru", "name": "DMIR_AUTH", "value": "xxx", ...}, ...] ``` 2. **Simple dict** (после ручной конвертации): ```json {"DMIR_AUTH": "xxx", "_CIAN_GK": "yyy", ...} ``` Page detects format и converts to dict client-side. Preview "Detected N cookies: name1, name2, ..." обновляется на каждый keystroke (pure synchronous parse). ### Upload flow 1. Paste JSON в textarea (rows=15, monospace) 2. Live preview shows detected cookie count 3. Click "Upload" → POST `/api/v1/admin/scrape/cian/upload-cookies` 4. Response: `{ok: true, userId: ..., cookieCount: ...}` (success) или error message 5. Backend verifies через `/kalkulator-nedvizhimosti/` (auth check) → encrypt → DB ### Test current session Separate button "Test Auth" → GET `/api/v1/admin/scrape/cian/test-auth` Returns: `{authenticated: true, userId: ...}` или `{authenticated: false, reason: ...}` `useQuery` with `enabled: false` + `.refetch()` — manual trigger, no auto-fetch on mount. ## Patterns reused - Auth: `localStorage.getItem("admin_token")` + `X-Admin-Token` header (same as `/admin/scrape/page.tsx`) - Styling: `cardStyle`/`inputStyle`/`labelStyle` from `@/lib/adminStyles` - API: `apiFetch` from `@/lib/api` - TanStack Query `useMutation` для POST, `useQuery` (enabled:false) для on-demand GET ## TS strict - `Record<string, string>` для cookie dict - `UploadResponse` / `TestAuthResponse` interfaces - No `any` types - Coerce values to `String(v)` в conversion (handles numeric / boolean values) ## Security - No `dangerouslySetInnerHTML` (JSON stays в textarea value) - Admin token из localStorage (existing project pattern) - Cookies marked sensitive — UI clears textarea на successful upload (optional — TBD UX preference) ## Push verify LOCAL == REMOTE = `b92eb81f` ## Decisions 1. Path is `/admin/scrape/cian-cookies` (not `/trade-in/admin/...`) — no `(trade-in)` route group exists; admin pages live under `/admin/scrape/` 2. `useQuery` with `enabled: false` for test-auth — cleaner than `useMutation` для GET, avoids auto-fetch anti-pattern 3. `uploadMutation.reset()` on textarea change — clears stale success/error banners ## Refs - PR #457 (Stage 4 — backend endpoints + scripts/upload-cian-cookies.sh) - PR #465 (Stage 7 — cian_valuation.py uses uploaded session) - Sibling fix PR (`feat/tradein-cian-cookies-real-list`) — fixes backend filter list ## Test plan - [x] TS strict compile clean - [x] Page renders без runtime errors - [ ] Post-deploy: paste Cookie-Editor JSON → preview detects N cookies → upload returns 200 + userId - [ ] Test Auth button shows current session state

lekss361 added 1 commit 2026-05-23 14:49:26 +00:00

feat(tradein-ui): Cian cookies upload admin page (paste JSON → POST /admin/scrape/cian/upload-cookies)

CI / backend (pull_request) Failing after 44s

Details

CI / frontend (pull_request) Successful in 1m38s

Details

b92eb81f2d

New page at /admin/scrape/cian-cookies:
- Textarea for pasting Cookie-Editor array or plain dict JSON
- Client-side format auto-detection and conversion
- Live preview: detected N cookies with key names
- Upload button → POST /api/v1/admin/scrape/cian/upload-cookies
- Test Session button → GET /api/v1/admin/scrape/cian/test-auth
- Error/success inline banners, collapsible instructions
- Admin token from localStorage (same pattern as /admin/scrape)
- Tab added to admin nav layout

Backend endpoints from PR #457 (Stage 4).

lekss361 referenced this pull request

2026-05-23 14:52:58 +00:00

fix(tradein): CIAN_REQUIRED_COOKIES — add real auth cookies (DMIR_AUTH + Cian session) #480

lekss361 commented

2026-05-23 14:54:20 +00:00

Author

Owner

Deep Code Review — verdict

Summary

Status: HIGH — BLOCK merge (routing bug, will 404 at runtime)
Files reviewed: 2 (P2: 2)
Lines: +463 / -0
PR: #481

CRITICAL — routing mismatch (BLOCK)

Backend endpoints /api/v1/admin/scrape/cian/upload-cookies и /api/v1/admin/scrape/cian/test-auth живут только в tradein-mvp/backend/app/api/v1/admin.py (lines 244, 290). В main backend (backend/app/api/v1/admin_scrape.py и других admin_*.py) этих роутов НЕТ — grep cian по backend/app/api/v1/ → 0 matches.

Caddy маршрутизация:

handle /trade-in/api/* {
    uri strip_prefix /trade-in
    reverse_proxy tradein-backend:8000
}

Tradein backend reachable ТОЛЬКО через префикс /trade-in/api/....

Что делает этот PR:

Page в frontend/src/app/admin/scrape/cian-cookies/page.tsx (main app под gendsgn.ru/admin/...)
apiFetch("/api/v1/admin/scrape/cian/upload-cookies", ...) → API_BASE_URL="" + path → fetch к https://gendsgn.ru/api/v1/admin/scrape/cian/upload-cookies
Caddy маршрут НЕ совпадает с /trade-in/api/* → попадает в main gendesign-backend:8000 → 404 Not Found на оба endpoints

Симптом: страница откроется, paste JSON будет работать, но Upload Cookies и Test Current Session будут возвращать API error 404: Not Found. Backend cian_session.upload-cookies никогда не получит запрос.

Fix options

Option A (recommended) — переместить страницу в tradein-mvp frontend:

Создать tradein-mvp/frontend/src/app/admin/scrape/cian-cookies/page.tsx
Tradein-mvp Next.js имеет basePath=/trade-in → URL станет https://gendsgn.ru/trade-in/admin/scrape/cian-cookies
apiFetch в tradein-mvp (учитывая basePath) → /trade-in/api/v1/admin/scrape/cian/upload-cookies → Caddy strip → tradein backend OK
Этот path соответствует архитектуре: cian/tradein endpoints в tradein-mvp/backend

Option B — оставить в main frontend, но переписать paths:

apiFetch("/trade-in/api/v1/admin/scrape/cian/upload-cookies", ...)
apiFetch("/trade-in/api/v1/admin/scrape/cian/test-auth", ...)

Это рабочий вариант, но архитектурно странно: main frontend/src/app/admin/ дёргает tradein backend. Лучше A.

Option C — добавить cian routes в main backend (с проксированием в tradein) — overkill для одной admin утилиты.

HIGH — auth pattern (NOT blocker, see note)

Per prompt narrative о PRs #437/#442/#474 «removed X-Admin-Token» — prompt narrative неверный для main backend: grep require_admin backend/app/api/v1/ → 6 файлов (admin_weight_profiles, admin_scrape, admin_jobs, admin_leads, admin_cadastre, admin_etl) всё ещё используют X-Admin-Token. api-types.ts (auto-gen из main OpenAPI) содержит 26 ссылок на X-Admin-Token — то есть main backend admin endpoints по-прежнему требуют header.

Tradein backend (tradein-mvp/backend/app/api/v1/admin.py:1-4) — auth gate'ится Caddy basic_auth, application layer открыт. Endpoints upload_cian_cookies / test_cian_auth НЕ требуют X-Admin-Token.

Что делает этот PR в коде:

headers: { "X-Admin-Token": token }

После fix routing (Option A или B):

Запрос дойдёт до tradein backend, который header игнорирует (нет dependency на verification)
Header передаётся через Caddy на /trade-in/api/* — basic_auth Caddy header не проверяет (это Authorization, не X-Admin-Token), header просто проксируется и игнорируется backend
Harmless dead code для tradein endpoints, но не блокирует

Recommendation после fix routing: убрать X-Admin-Token header и весь Admin Token input UI — для tradein endpoints не нужен. Auth — это basic_auth Caddy (browser prompt). Это уберёт confusion + dead pattern.

MEDIUM — другие observations

previewKeys.length > 0 без минимальной валидации (page.tsx:122). Можно paste {} → preview "Detected 0 cookies" → canUpload=false (good due to previewKeys.length > 0). OK.
Textarea не очищается на success (page.tsx:175). Cookies остаются в DOM/memory после успешного upload. Minor security concern (admin tool, browser context). Suggest:
```
const uploadMutation = useMutation({
  mutationFn: () => { ... },
  onSuccess: () => setRawInput(""),
});
```
String(null) → "null" (page.tsx:30, 47). Cookie value === null → backend получит строку "null". Per tradein-mvp/backend/app/api/v1/admin.py:265, фильтр CIAN_REQUIRED_COOKIES сработает только если ключ в whitelist — null-value cookie с правильным ключом пройдёт. Edge case acceptable для admin tool.
uploadMutation.reset() on textarea change (page.tsx:218-222) — корректно, очищает stale banner.
Inline styles vs design tokens (ui-ux.md rule). Page широко использует inline hex: #1d4ed8, #5b6066, #fef2f2, #f0fdf4, #991b1b, etc. Per ui-ux.md «Inline hex вне токенов — нарушение». Но: соседняя admin/scrape/page.tsx тоже inline-hex (legacy admin pattern, не unified в design tokens). Не блокер — consistency с existing admin style, но suggest follow-up: создать adminStyles.ts colors export.
Emoji в layout tab label (layout.tsx:12): "Cian Cookies" — без emoji в отличие от других tabs (📊, 🗺, 🏗). Inconsistent + ui-ux.md «НЕ emoji в UI». Можно оставить как есть (consistency wave должен идти отдельным PR), но strict ui-ux.md говорит убрать все emoji. Acceptable как inconsistency-fix.
No dangerouslySetInnerHTML — verified. No XSS surface.
TS strict — verified. Record<string, string>, CookieEditorEntry, UploadResponse, TestAuthResponse. No any. OK.
useQuery enabled: false + .refetch() pattern — корректно, no auto-fetch on mount.
JSON parse safety: JSON.parse(input.trim()) в convertCookiesFormat обёрнут в try/catch через parsePreview (page.tsx:51-60). Invalid JSON → user-friendly error в preview. OK.

Cross-PR coordination

PR #480 (CIAN_REQUIRED_COOKIES real list) — должен merge ПЕРВЫМ, иначе фильтр cleaned = {k: v for k, v in cookies.items() if k in CIAN_REQUIRED_COOKIES} (admin.py:265) выбросит реальные DMIR_AUTH cookies и вернёт 400.
PR #481 — после fix routing + после #480.

Vault cross-check

decisions/ поиск cian.*cookies — нет существующего decision для encryption strategy / admin auth model для tradein admin endpoints
Создать после merge: code/modules/tradein/Frontend_Cian_Cookies_Upload.md с note о Caddy basic_auth модели (не X-Admin-Token)
Vault entry для routing convention: «tradein-mvp/frontend/ обслуживает /trade-in/*, main frontend/ — gendsgn.ru/*; не пересекать»

Pre-flight

Branch: feat/tradein-cian-cookies-ui (feature branch, not main) — OK
mergeable: true, no conflicts с merged main — OK
No --no-verify / --force / --amend in commits — OK
Head SHA stable: b92eb81f

Verdict

BLOCK — routing bug critical (404 at runtime), PR в текущем виде нерабочий end-to-end.

Next steps:

Worker (frontend-engineer): выбрать Option A (рекомендую — переместить в tradein-mvp/frontend/src/app/admin/scrape/cian-cookies/page.tsx) или Option B (заменить path на /trade-in/api/v1/admin/scrape/cian/...)
Убрать X-Admin-Token header + Admin Token input (tradein endpoints не требуют, auth через Caddy basic_auth)
Если Option A — добавить tab entry в tradein-mvp/frontend/src/app/admin/layout.tsx (или соответствующий admin layout tradein), а не в main frontend/src/app/admin/layout.tsx
onSuccess: () => setRawInput("") — clear textarea on success (security hygiene)
Merge PR #480 ПЕРВЫМ
После rebuild — verify через chrome-devtools / curl: paste JSON → 200 + userId

PR не мержится до fix routing.

## Deep Code Review — verdict ### Summary - **Status**: HIGH — BLOCK merge (routing bug, will 404 at runtime) - **Files reviewed**: 2 (P2: 2) - **Lines**: +463 / -0 - **PR**: #481 --- ### CRITICAL — routing mismatch (BLOCK) **Backend endpoints `/api/v1/admin/scrape/cian/upload-cookies` и `/api/v1/admin/scrape/cian/test-auth` живут только в `tradein-mvp/backend/app/api/v1/admin.py` (lines 244, 290).** В main backend (`backend/app/api/v1/admin_scrape.py` и других `admin_*.py`) этих роутов **НЕТ** — grep `cian` по `backend/app/api/v1/` → 0 matches. Caddy маршрутизация: ``` handle /trade-in/api/* { uri strip_prefix /trade-in reverse_proxy tradein-backend:8000 } ``` Tradein backend reachable ТОЛЬКО через префикс `/trade-in/api/...`. Что делает этот PR: - Page в `frontend/src/app/admin/scrape/cian-cookies/page.tsx` (main app под `gendsgn.ru/admin/...`) - `apiFetch("/api/v1/admin/scrape/cian/upload-cookies", ...)` → `API_BASE_URL=""` + path → fetch к `https://gendsgn.ru/api/v1/admin/scrape/cian/upload-cookies` - Caddy маршрут НЕ совпадает с `/trade-in/api/*` → попадает в main `gendesign-backend:8000` → **404 Not Found** на оба endpoints **Симптом**: страница откроется, paste JSON будет работать, но `Upload Cookies` и `Test Current Session` будут возвращать `API error 404: Not Found`. Backend `cian_session.upload-cookies` никогда не получит запрос. ### Fix options **Option A (recommended)** — переместить страницу в tradein-mvp frontend: - Создать `tradein-mvp/frontend/src/app/admin/scrape/cian-cookies/page.tsx` - Tradein-mvp Next.js имеет `basePath=/trade-in` → URL станет `https://gendsgn.ru/trade-in/admin/scrape/cian-cookies` - `apiFetch` в tradein-mvp (учитывая basePath) → `/trade-in/api/v1/admin/scrape/cian/upload-cookies` → Caddy strip → tradein backend OK - Этот path соответствует архитектуре: cian/tradein endpoints в tradein-mvp/backend **Option B** — оставить в main frontend, но переписать paths: ```ts apiFetch("/trade-in/api/v1/admin/scrape/cian/upload-cookies", ...) apiFetch("/trade-in/api/v1/admin/scrape/cian/test-auth", ...) ``` Это рабочий вариант, но архитектурно странно: main `frontend/src/app/admin/` дёргает tradein backend. Лучше A. **Option C** — добавить cian routes в main backend (с проксированием в tradein) — overkill для одной admin утилиты. --- ### HIGH — auth pattern (NOT blocker, see note) Per prompt narrative о PRs #437/#442/#474 «removed X-Admin-Token» — **prompt narrative неверный для main backend**: `grep require_admin backend/app/api/v1/` → 6 файлов (admin_weight_profiles, admin_scrape, admin_jobs, admin_leads, admin_cadastre, admin_etl) **всё ещё используют X-Admin-Token**. `api-types.ts` (auto-gen из main OpenAPI) содержит 26 ссылок на `X-Admin-Token` — то есть main backend admin endpoints **по-прежнему требуют header**. Tradein backend (`tradein-mvp/backend/app/api/v1/admin.py:1-4`) — auth gate'ится Caddy basic_auth, application layer открыт. Endpoints `upload_cian_cookies` / `test_cian_auth` НЕ требуют `X-Admin-Token`. Что делает этот PR в коде: ```tsx headers: { "X-Admin-Token": token } ``` После fix routing (Option A или B): - Запрос дойдёт до **tradein backend**, который header **игнорирует** (нет dependency на verification) - Header передаётся через Caddy на `/trade-in/api/*` — basic_auth Caddy header не проверяет (это Authorization, не X-Admin-Token), header просто проксируется и игнорируется backend - **Harmless dead code** для tradein endpoints, но не блокирует **Recommendation после fix routing**: убрать `X-Admin-Token` header и весь `Admin Token` input UI — для tradein endpoints не нужен. Auth — это basic_auth Caddy (browser prompt). Это уберёт confusion + dead pattern. --- ### MEDIUM — другие observations 1. **`previewKeys.length > 0` без минимальной валидации** (`page.tsx:122`). Можно paste `{}` → preview "Detected 0 cookies" → canUpload=false (good due to `previewKeys.length > 0`). OK. 2. **Textarea не очищается на success** (`page.tsx:175`). Cookies остаются в DOM/memory после успешного upload. Minor security concern (admin tool, browser context). Suggest: ```tsx const uploadMutation = useMutation({ mutationFn: () => { ... }, onSuccess: () => setRawInput(""), }); ``` 3. **`String(null)` → `"null"`** (`page.tsx:30, 47`). Cookie value === `null` → backend получит строку `"null"`. Per `tradein-mvp/backend/app/api/v1/admin.py:265`, фильтр `CIAN_REQUIRED_COOKIES` сработает только если ключ в whitelist — null-value cookie с правильным ключом пройдёт. Edge case acceptable для admin tool. 4. **`uploadMutation.reset()` on textarea change** (`page.tsx:218-222`) — корректно, очищает stale banner. 5. **Inline styles vs design tokens** (`ui-ux.md` rule). Page широко использует inline hex: `#1d4ed8`, `#5b6066`, `#fef2f2`, `#f0fdf4`, `#991b1b`, etc. Per ui-ux.md «Inline hex вне токенов — нарушение». Но: соседняя `admin/scrape/page.tsx` тоже inline-hex (legacy admin pattern, не unified в design tokens). Не блокер — consistency с existing admin style, но **suggest follow-up**: создать `adminStyles.ts` colors export. 6. **Emoji в layout tab label** (`layout.tsx:12`): `"Cian Cookies"` — без emoji в отличие от других tabs (`📊`, `🗺`, `🏗`). Inconsistent + ui-ux.md «НЕ emoji в UI». Можно оставить как есть (consistency wave должен идти отдельным PR), но **strict ui-ux.md** говорит убрать все emoji. Acceptable как inconsistency-fix. 7. **No `dangerouslySetInnerHTML`** — verified. No XSS surface. 8. **TS strict** — verified. `Record<string, string>`, `CookieEditorEntry`, `UploadResponse`, `TestAuthResponse`. No `any`. OK. 9. **`useQuery enabled: false` + `.refetch()` pattern** — корректно, no auto-fetch on mount. 10. **JSON parse safety**: `JSON.parse(input.trim())` в `convertCookiesFormat` обёрнут в `try/catch` через `parsePreview` (`page.tsx:51-60`). Invalid JSON → user-friendly error в preview. OK. --- ### Cross-PR coordination - **PR #480** (`CIAN_REQUIRED_COOKIES` real list) — должен merge ПЕРВЫМ, иначе фильтр `cleaned = {k: v for k, v in cookies.items() if k in CIAN_REQUIRED_COOKIES}` (`admin.py:265`) выбросит реальные DMIR_AUTH cookies и вернёт 400. - **PR #481** — после fix routing + после #480. ### Vault cross-check - `decisions/` поиск `cian.*cookies` — нет существующего decision для encryption strategy / admin auth model для tradein admin endpoints - Создать после merge: `code/modules/tradein/Frontend_Cian_Cookies_Upload.md` с note о Caddy basic_auth модели (не X-Admin-Token) - Vault entry для routing convention: «`tradein-mvp/frontend/` обслуживает `/trade-in/*`, main `frontend/` — gendsgn.ru/*; не пересекать» ### Pre-flight - Branch: `feat/tradein-cian-cookies-ui` (feature branch, not main) — OK - mergeable: true, no conflicts с merged main — OK - No `--no-verify` / `--force` / `--amend` in commits — OK - Head SHA stable: `b92eb81f` ### Verdict **BLOCK** — routing bug critical (404 at runtime), PR в текущем виде нерабочий end-to-end. **Next steps**: 1. Worker (frontend-engineer): выбрать Option A (рекомендую — переместить в `tradein-mvp/frontend/src/app/admin/scrape/cian-cookies/page.tsx`) или Option B (заменить path на `/trade-in/api/v1/admin/scrape/cian/...`) 2. Убрать `X-Admin-Token` header + Admin Token input (tradein endpoints не требуют, auth через Caddy basic_auth) 3. Если Option A — добавить tab entry в `tradein-mvp/frontend/src/app/admin/layout.tsx` (или соответствующий admin layout tradein), а не в main `frontend/src/app/admin/layout.tsx` 4. `onSuccess: () => setRawInput("")` — clear textarea on success (security hygiene) 5. Merge PR #480 ПЕРВЫМ 6. После rebuild — verify через chrome-devtools / curl: paste JSON → 200 + userId PR не мержится до fix routing.

lekss361 added 2 commits 2026-05-23 15:16:35 +00:00

Merge remote-tracking branch 'forgejo/main' into feat/tradein-cian-cookies-ui 6c4e5a6809

fix(tradein-ui): move Cian cookies upload page to tradein-mvp frontend (routing fix) 02c2ce6cd3

- Move page from main frontend to tradein-mvp/frontend/src/app/scrapers/cian-cookies/
  so /trade-in/api/* Caddy route maps to tradein backend (where
  /admin/scrape/cian/upload-cookies endpoint lives)
- Remove X-Admin-Token header (tradein admin endpoints don't require it;
  auth = Caddy basic_auth) and remove localStorage token state
- Clear textarea on successful upload (security hygiene per review)
- Add Cian Cookies tab to tradein-mvp Topbar nav
- Revert tab entry in main frontend admin layout

lekss361 commented

2026-05-23 15:17:38 +00:00

Author

Owner

Fixup commit 02c2ce6 pushed — addresses BLOCK routing bug.

Resolution

Routing fix (Option A — moved to tradein-mvp/frontend):

❌ Deleted: frontend/src/app/admin/scrape/cian-cookies/page.tsx
❌ Reverted: frontend/src/app/admin/layout.tsx (tab removed)
✅ Created: tradein-mvp/frontend/src/app/scrapers/cian-cookies/page.tsx (351 lines)
✅ Modified: tradein-mvp/frontend/src/components/trade-in/Topbar.tsx (+14 lines — cian-cookies в ActiveTab union + NAV_ITEMS)

Final URL: https://gendsgn.ru/trade-in/scrapers/cian-cookies

Now requests hit /trade-in/api/* → Caddy → tradein backend (where cian endpoints live) → 200 OK instead of 404.

Other reviewer points addressed

✅ X-Admin-Token header полностью removed (UI + headers + token state). Tradein admin endpoints не требуют — auth через Caddy basic_auth.
✅ onSuccess: () => setRawInput("") — clears textarea on successful upload (security hygiene).
Tab styling: matches existing tradein-mvp Topbar pattern (consistent с avito/yandex scraper pages).

Deviation

URL pattern /scrapers/cian-cookies (not /admin/scrape/cian-cookies) — tradein-mvp frontend uses flat /scrapers/ структуру: avito/yandex pages там же. Matches existing convention.

Verify

LOCAL == REMOTE = 02c2ce6 ✅
TS check clean
PR diff vs main: only 2 files (351 + 14 lines) — main frontend changes cancelled out by deletion

Ready for re-review.

Fixup commit `02c2ce6` pushed — addresses BLOCK routing bug. ## Resolution **Routing fix (Option A — moved to tradein-mvp/frontend)**: - ❌ Deleted: `frontend/src/app/admin/scrape/cian-cookies/page.tsx` - ❌ Reverted: `frontend/src/app/admin/layout.tsx` (tab removed) - ✅ Created: `tradein-mvp/frontend/src/app/scrapers/cian-cookies/page.tsx` (351 lines) - ✅ Modified: `tradein-mvp/frontend/src/components/trade-in/Topbar.tsx` (+14 lines — `cian-cookies` в `ActiveTab` union + `NAV_ITEMS`) **Final URL**: `https://gendsgn.ru/trade-in/scrapers/cian-cookies` Now requests hit `/trade-in/api/*` → Caddy → tradein backend (where cian endpoints live) → 200 OK instead of 404. ## Other reviewer points addressed - ✅ `X-Admin-Token` header полностью removed (UI + headers + token state). Tradein admin endpoints не требуют — auth через Caddy basic_auth. - ✅ `onSuccess: () => setRawInput("")` — clears textarea on successful upload (security hygiene). - Tab styling: matches existing tradein-mvp `Topbar` pattern (consistent с avito/yandex scraper pages). ## Deviation URL pattern `/scrapers/cian-cookies` (not `/admin/scrape/cian-cookies`) — tradein-mvp frontend uses flat `/scrapers/` структуру: avito/yandex pages там же. Matches existing convention. ## Verify - LOCAL == REMOTE = `02c2ce6` ✅ - TS check clean - PR diff vs main: only 2 files (351 + 14 lines) — main frontend changes cancelled out by deletion Ready for re-review.

lekss361 merged commit 65029cd1a7 into main

2026-05-23 15:19:43 +00:00

lekss361 referenced this pull request from a commit

2026-05-23 15:19:43 +00:00

feat(tradein-ui): Cian cookies upload admin page (#481)

lekss361 commented

2026-05-23 15:20:04 +00:00

Author

Owner

Merged via deep-code-reviewer — verdict APPROVE.

Routing fix confirmed:

File moved to tradein-mvp/frontend/src/app/scrapers/cian-cookies/page.tsx (tradein app, basePath=/trade-in)
apiFetch resolves to tradein-mvp/frontend/src/lib/api.ts → ${API_BASE_URL}${path} → /trade-in/api/v1/admin/scrape/cian/upload-cookies → Caddy handle_path /trade-in/api/* → tradein-backend
X-Admin-Token header + localStorage state fully removed (no references anywhere in tradein-mvp/frontend)
Textarea clears on success via onSuccess: () => setRawInput("")
Tab wiring moved from main frontend/src/app/admin/layout.tsx → tradein-mvp/src/components/trade-in/Topbar.tsx (/scrapers/cian-cookies)
TS strict: Record<string, string>, UploadResponse, TestAuthResponse, CookieEditorEntry — no any
useQuery enabled:false + .refetch() pattern preserved

Merge SHA: 65029cd1a7622ebb5825ac07e221a8a53436064b.

Merged via deep-code-reviewer — verdict APPROVE. Routing fix confirmed: - File moved to `tradein-mvp/frontend/src/app/scrapers/cian-cookies/page.tsx` (tradein app, basePath=/trade-in) - `apiFetch` resolves to `tradein-mvp/frontend/src/lib/api.ts` → `${API_BASE_URL}${path}` → `/trade-in/api/v1/admin/scrape/cian/upload-cookies` → Caddy `handle_path /trade-in/api/*` → tradein-backend - `X-Admin-Token` header + localStorage state fully removed (no references anywhere in tradein-mvp/frontend) - Textarea clears on success via `onSuccess: () => setRawInput("")` - Tab wiring moved from main `frontend/src/app/admin/layout.tsx` → `tradein-mvp/src/components/trade-in/Topbar.tsx` (`/scrapers/cian-cookies`) - TS strict: `Record<string, string>`, `UploadResponse`, `TestAuthResponse`, `CookieEditorEntry` — no `any` - `useQuery enabled:false` + `.refetch()` pattern preserved Merge SHA: `65029cd1a7622ebb5825ac07e221a8a53436064b`.

lekss361 referenced this pull request

2026-05-23 15:32:12 +00:00

feat(tradein-ui): Cian scraper admin page + global request delay control #486