lekss361/gendesign

fix(tradein/pdf): scale offer-page rent by room count (LOW audit R2 #5) #2506

Merged

bot-backend merged 1 commit from fix/tradein-pdf-offer-rent-scaling into main

2026-07-12 22:11:05 +00:00

bot-backend commented

2026-07-12 22:07:37 +00:00

Collaborator

LOW audit round-2 #5. The offer page hardcoded a 1-room 3-month rent (84-135k) in 'Общие финансовые потери' for every object regardless of size. Thread input_snapshot into _build_offer_page and scale rent by rooms (EKB heuristic 1.0/1.35/1.8/2.4); relabel the rent row with the object's actual room count. Legal/advertising stay flat (per-transaction). New tests assert scaling + subtitle. 95 tests passed.

LOW audit round-2 #5. The offer page hardcoded a 1-room 3-month rent (84-135k) in 'Общие финансовые потери' for every object regardless of size. Thread input_snapshot into _build_offer_page and scale rent by rooms (EKB heuristic 1.0/1.35/1.8/2.4); relabel the rent row with the object's actual room count. Legal/advertising stay flat (per-transaction). New tests assert scaling + subtitle. 95 tests passed.

bot-backend added 1 commit 2026-07-12 22:07:38 +00:00

fix(tradein/pdf): scale offer-page rent by room count instead of flat 1-room figure

CI Trade-In / changes (pull_request) Successful in 11s

Details

CI / changes (pull_request) Successful in 10s

Details

CI / backend-tests (pull_request) Has been skipped

Details

CI / frontend-tests (pull_request) Has been skipped

Details

CI / openapi-codegen-check (pull_request) Has been skipped

Details

CI Trade-In / frontend-checks (pull_request) Has been skipped

Details

CI Trade-In / backend-tests (pull_request) Successful in 1m0s

Details

'Общие финансовые потери' hardcoded a 1-room 3-month rent (84-135k) for every
object regardless of size. Thread input_snapshot into _build_offer_page and scale
rent by rooms (EKB heuristic); relabel the rent row with the object's actual room
count. Legal/advertising stay flat (per-transaction). LOW audit R2 (#5).

bot-backend merged commit 92371e7d9e into main

2026-07-12 22:11:05 +00:00

bot-backend deleted branch fix/tradein-pdf-offer-rent-scaling

2026-07-12 22:11:06 +00:00

bot-backend referenced this pull request from a commit

2026-07-12 22:11:06 +00:00

fix(tradein/pdf): scale offer-page rent by room count (LOW audit R2 #5) (#2506)

Sign in to join this conversation.

No reviewers

No labels

Fable 5 ревью

GG-форсайт

needs-discussion

status/needs-analysis

status/needs-fix

week ревью 1

вторичка

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#2506

No description provided.