lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(tradein/scraper-kit): scale cian anchor watchdog for proxy-pool browser fetches (#2160) #2272

Merged
lekss361 merged 1 commit from fix/tradein-cian-anchor-timeout-pool into main 2026-07-03 07:09:51 +00:00
Conversation 0 Commits 1 Files changed 3 +181 -6
lekss361 commented 2026-07-03 07:06:32 +00:00
Owner
Copy link

Summary

  • Прод-факт (активация pool_browser, run 581): через пул каждый cian SERP-фетч = 13-45s (camoufox relaunch при смене прокси). Якорь = 4 room-buckets × 3 страницы + detail_top_n + houses — суммарно >>240s. Фиксированный ANCHOR_TIMEOUT_SEC=240 гильотинил КАЖДЫЙ якорь до save_listings → lots_fetched=0, после 3 подряд → mark_banned (ложный «бан» при живых фетчах: SERP стабильно отдавал 28 lots/страницу).
  • Фикс: масштабируемый watchdog _cian_anchor_timeout_s() по прецеденту avito (~pipeline:799) / yandex-combos (~1686) / domclick (~3306): max(240, 4×pages×(delay+70s) + detail_top_n×50s + houses 180s) = 1580s при дефолтах (worst-case защита от зависания, не ожидаемая длительность). INFO-лог с разбивкой, WARNING/mark_banned-сообщения показывают вычисленное значение.
  • Правка применена к обеим копиям (scraper_kit + legacy app/services/scrape_pipeline.py — живёт для admin-триггера и flag-off fallback до cleanup-волны strangler'а) + parity-тест синхрона формул.

Test plan

  • 23 passed (test_cian_city_sweep.py, 4 новых: формула при дефолтах, floor 240s, без houses, parity kit↔legacy), ruff clean
  • Post-deploy: re-poke cian_city_sweep → якоря проходят, lots сохраняются, статус done

Refs #2126, #2160

## Summary - **Прод-факт (активация pool_browser, run 581):** через пул каждый cian SERP-фетч = 13-45s (camoufox relaunch при смене прокси). Якорь = 4 room-buckets × 3 страницы + detail_top_n + houses — суммарно >>240s. Фиксированный `ANCHOR_TIMEOUT_SEC=240` гильотинил КАЖДЫЙ якорь до save_listings → `lots_fetched=0`, после 3 подряд → `mark_banned` (ложный «бан» при живых фетчах: SERP стабильно отдавал 28 lots/страницу). - **Фикс:** масштабируемый watchdog `_cian_anchor_timeout_s()` по прецеденту avito (~pipeline:799) / yandex-combos (~1686) / domclick (~3306): `max(240, 4×pages×(delay+70s) + detail_top_n×50s + houses 180s)` = 1580s при дефолтах (worst-case защита от зависания, не ожидаемая длительность). INFO-лог с разбивкой, WARNING/mark_banned-сообщения показывают вычисленное значение. - Правка применена к **обеим копиям** (scraper_kit + legacy `app/services/scrape_pipeline.py` — живёт для admin-триггера и flag-off fallback до cleanup-волны strangler'а) + parity-тест синхрона формул. ## Test plan - [x] 23 passed (`test_cian_city_sweep.py`, 4 новых: формула при дефолтах, floor 240s, без houses, parity kit↔legacy), ruff clean - [ ] Post-deploy: re-poke `cian_city_sweep` → якоря проходят, lots сохраняются, статус done Refs #2126, #2160
lekss361 added 1 commit 2026-07-03 07:06:32 +00:00
fix(tradein/scraper-kit): scale cian anchor watchdog for proxy-pool browser fetches (#2160)
All checks were successful
CI Trade-In / changes (pull_request) Successful in 11s
Details
CI / changes (pull_request) Successful in 11s
Details
CI Trade-In / frontend-checks (pull_request) Has been skipped
Details
CI / backend-tests (pull_request) Has been skipped
Details
CI / frontend-tests (pull_request) Has been skipped
Details
CI / openapi-codegen-check (pull_request) Has been skipped
Details
CI Trade-In / backend-tests (pull_request) Successful in 1m51s
Details
8a10d943d7 
Fixed ANCHOR_TIMEOUT_SEC=240 guillotined every cian anchor when running via
USE_PROXY_POOL_BROWSER=true: each SERP fetch goes through camoufox with relaunch
on proxy swap (13-45s/page), and an anchor = 4 room-buckets x pages_per_anchor
SERP fetches + detail_top_n details + houses-enrich >> 240s. save_listings never
ran, lots_fetched=0, and after 3 consecutive skips the run was mark_banned.

Introduces _cian_anchor_timeout_s() mirroring the avito/yandex/domclick scaling
pattern: max(ANCHOR_TIMEOUT_SEC, buckets*pages*(delay+per_serp) + details*per_detail
+ houses_budget). Defaults -> 1580s worst-case watchdog (hang guard, not expected
duration). Applied to both the scraper-kit copy (strangler target) and the active
app.services.scrape_pipeline copy that run 581 actually hit.
lekss361 merged commit 68429967ab into main 2026-07-03 07:09:51 +00:00
lekss361 deleted branch fix/tradein-cian-anchor-timeout-pool 2026-07-03 07:09:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#2272
No description provided.
Delete branch "fix/tradein-cian-anchor-timeout-pool"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?