refactor(tradein/estimator): extract deterministic pricing into pure _price_from_inputs (#1966 foundation) #1976

Merged

lekss361 merged 2 commits from refactor/tradein-estimator-price-spine into main

2026-06-27 10:13:34 +00:00

lekss361 commented

2026-06-27 10:12:13 +00:00

Owner

Summary

Foundation refactor for #1966 (accuracy-loop → CI gate). Extracts the deterministic pricing orchestration out of the async estimate_quality into a new pure, synchronous _price_from_inputs() — single source of truth — so the pricing spine becomes unit-testable and reusable by an offline backtest harness.

All DB/network fetches stay in estimate_quality; their results are injected into the pure function: pre-fetched objects (dkp_raw, imv_anchor, anchor_comps, imv_eval, presence flags for yandex/cian) + 3 thin callables (ratio_resolver, quarter_index_lookup, quarter_indexes_lookup) for lookups whose arguments are computed mid-block.
PricingResult dataclass (19 fields) carries everything estimate_quality consumes downstream (DB INSERT, analogs/anchor selection, freshness, AggregatedEstimate).
Behavior-preserving MOVE, not a rewrite. Mutation order unchanged: median→repair→anchor(+gates)→IMV-blend→quarter-index→corridor-clamp→expected_sold→advisory→coarse-geo.

Test plan

Full suite green, no existing test modified: 2443 passed, 2 skipped, 0 failures. (5 collection errors are pre-existing site-finder tests outside tradein-mvp, env-only — unrelated.)
New tests/test_estimator_price_spine.py (401 lines, hermetic/no-DB) covers: radius-only, anchor Tier A, Tier C corridor gate, ghost-anchor, quarter-index (apply + Guard-2 skip), corridor clamp, expected_sold presence/absence, coarse-geo downgrade.
code-reviewer: ✅ APPROVE — zero output divergence across 7 risk vectors (ratio timing, IMV pre-fetch, cian/yandex presence, quarter guards, mutation order, PricingResult completeness, psycopg/ruff).
ruff clean.

Unblocks PR2 (backtest harness on _price_from_inputs + range-coverage + confidence-calibration + frozen baseline) and PR3 (CI regression gate).

Part of #1966 (PR 1/3). Refs #1966.

## Summary Foundation refactor for #1966 (accuracy-loop → CI gate). Extracts the deterministic pricing orchestration out of the async `estimate_quality` into a new **pure, synchronous** `_price_from_inputs()` — single source of truth — so the pricing spine becomes unit-testable and reusable by an offline backtest harness. - All DB/network fetches stay in `estimate_quality`; their results are injected into the pure function: pre-fetched objects (`dkp_raw`, `imv_anchor`, `anchor_comps`, `imv_eval`, presence flags for yandex/cian) + 3 thin callables (`ratio_resolver`, `quarter_index_lookup`, `quarter_indexes_lookup`) for lookups whose arguments are computed mid-block. - `PricingResult` dataclass (19 fields) carries everything `estimate_quality` consumes downstream (DB INSERT, analogs/anchor selection, freshness, `AggregatedEstimate`). - **Behavior-preserving MOVE, not a rewrite.** Mutation order unchanged: median→repair→anchor(+gates)→IMV-blend→quarter-index→corridor-clamp→expected_sold→advisory→coarse-geo. ## Test plan - [x] Full suite green, **no existing test modified**: 2443 passed, 2 skipped, 0 failures. (5 collection errors are pre-existing site-finder tests outside `tradein-mvp`, env-only — unrelated.) - [x] New `tests/test_estimator_price_spine.py` (401 lines, hermetic/no-DB) covers: radius-only, anchor Tier A, Tier C corridor gate, ghost-anchor, quarter-index (apply + Guard-2 skip), corridor clamp, expected_sold presence/absence, coarse-geo downgrade. - [x] `code-reviewer`: ✅ APPROVE — zero output divergence across 7 risk vectors (ratio timing, IMV pre-fetch, cian/yandex presence, quarter guards, mutation order, PricingResult completeness, psycopg/ruff). - [x] ruff clean. Unblocks **PR2** (backtest harness on `_price_from_inputs` + range-coverage + confidence-calibration + frozen baseline) and **PR3** (CI regression gate). Part of #1966 (PR 1/3). Refs #1966.

Rows
Columns