lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

feat(etl): housing-class normalization fallback via yandex_realty trigram match (#38) #1911

Merged
bot-backend merged 1 commit from feat/obj-class-normalization-38 into main 2026-06-26 07:44:26 +00:00
Conversation 0 Commits 1 Files changed 6 +640 -12
bot-backend commented 2026-06-26 07:31:10 +00:00
Collaborator
Copy link

Класс жилья normalization: для domrf_kn_objects без obj_class — fallback через trigram-match названия ЖК с yandex_realty + price-inference.

  • data/sql/169: obj_class_fallback + obj_class_source ('domrf'|'yandex_match'|'price_inference') колонки, pg_trgm + GIN trgm индексы. Idempotent.
  • etl/obj_class_backfill.py (по образцу objective_backfill.py): similarity() CROSS JOIN LATERAL, AUTO_ACCEPT 0.6 → yandex_match; price-inference fallback. SAVEPOINT per row, idempotent.
  • Консьюмеры (velocity/competitors/analytics_queries) читают COALESCE(obj_class, obj_class_fallback) — реальный класс всегда побеждает (byte-identical когда есть).
  • +8 тестов. 39 passed, ruff clean.

Без schema-change (внутренний backfill, obj_class-ключ ответа не меняется) → codegen не нужен.

⚠️ Покрытие зависит от расширения скрейпа yandex_realty_zk (сейчас ~12 строк; matcher+порог готовы, цифры покрытия — после скрейпа). Refs #38

Класс жилья normalization: для `domrf_kn_objects` без `obj_class` — fallback через trigram-match названия ЖК с yandex_realty + price-inference. - `data/sql/169`: `obj_class_fallback` + `obj_class_source` ('domrf'|'yandex_match'|'price_inference') колонки, pg_trgm + GIN trgm индексы. Idempotent. - `etl/obj_class_backfill.py` (по образцу objective_backfill.py): `similarity()` CROSS JOIN LATERAL, AUTO_ACCEPT 0.6 → yandex_match; price-inference fallback. SAVEPOINT per row, idempotent. - Консьюмеры (velocity/competitors/analytics_queries) читают `COALESCE(obj_class, obj_class_fallback)` — реальный класс всегда побеждает (byte-identical когда есть). - +8 тестов. 39 passed, ruff clean. **Без schema-change** (внутренний backfill, obj_class-ключ ответа не меняется) → codegen не нужен. ⚠️ Покрытие зависит от расширения скрейпа `yandex_realty_zk` (сейчас ~12 строк; matcher+порог готовы, цифры покрытия — после скрейпа). Refs #38
bot-backend added 1 commit 2026-06-26 07:31:11 +00:00
feat(etl): housing-class normalization fallback via yandex_realty trigram match (#38)
All checks were successful
CI / changes (pull_request) Successful in 6s
Details
CI / frontend-tests (pull_request) Has been skipped
Details
CI / openapi-codegen-check (pull_request) Successful in 2m14s
Details
CI / backend-tests (pull_request) Successful in 11m20s
Details
95b2fb34e2 
kn-API не отдаёт obj_class для ~3032 ЖК Свердл, что ломает per-class
velocity/absorption/weight. Добавлен fallback:

- 169_obj_class_fallback.sql: obj_class_fallback + obj_class_source колонки,
  pg_trgm + GIN trgm индексы на LOWER(comm_name) и LOWER(yandex_realty_zk.name).
- app/services/etl/obj_class_backfill.py: trigram-match comm_name ↔
  yandex_realty_zk.name (similarity >= 0.6, CROSS JOIN LATERAL) →
  obj_class_source='yandex_match'; price-inference по
  yandex_realty_class_prices → 'price_inference'. Idempotent, SAVEPOINT per row.
- Консьюмеры (analytics_queries / velocity / competitors): класс-фильтр и
  dominant_class читают COALESCE(obj_class, obj_class_fallback) — реальный
  класс в приоритете, поведение для размеченных ЖК не меняется.

Внутренний backfill — response-схема (parcel.py / OpenAPI) не меняется.

Refs #38
bot-backend merged commit 9c52e0b29f into main 2026-06-26 07:44:26 +00:00
bot-backend deleted branch feat/obj-class-normalization-38 2026-06-26 07:44:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1911
No description provided.
Delete branch "feat/obj-class-normalization-38"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?