fix(cadastre): NSPD response parse — properties.category + top-level meta (#168) #177

Merged
lekss361 merged 2 commits from fix/nspd-response-parse into main 2026-05-15 12:40:01 +00:00

2 commits

Author SHA1 Message Date
lekss361
4f4868412d fix(cadastre): test fixtures use real NSPD shape — properties.category + top-level meta (#168)
Bot review of #177 flagged that fixtures still used legacy properties.categoryId
+ data.meta — meaning CI exercised only fallback branches, not primary paths
where the actual bug lived. Pattern of 3 consecutive "live-only" parse fixes
(#175 verify, #176 headers, #177 parse) confirmed need for test coverage.

Changes:
- test_nspd_bulk_client.py: sample_quarter_response → properties.category +
  meta moved to top-level (real NSPD shape verified live)
- test_cadastre_bulk.py: 7 fixtures categoryId → category (regex replace)
- test_nspd_bulk_feature_parse_basic: primary path now exercised

Plus schema hardening per bot review:
- NSPDBulkFeature.category_id: `is not None` check (not truthy `or`)
  to avoid edge case category=0; int() wrapped in try/except so
  non-numeric ID (e.g. "ЗУ") doesn't crash upsert_features loop.

35/35 tests pass locally.
2026-05-15 15:33:25 +03:00
lekss361
b199c3f225 fix(cadastre): NSPD response parse — properties.category + top-level meta (#168) 2026-05-15 15:23:52 +03:00