lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(site-finder): 5 дефектов из фидбека analyze (#1736-1740) #1748

Merged
lekss361 merged 6 commits from fix/sf-feedback-batch into main 2026-06-18 07:06:47 +00:00
Conversation 0 Commits 6 Files changed 11 +380 -107
bot-backend commented 2026-06-18 06:47:26 +00:00
Collaborator
Copy link

Боевой фидбек Anton по analyze (cad 66:41:0702048:27) → 5 дефектов исправлено.

  • #1736 точки подключения на карте (MiniMap проброс, был только legacy) — verified live: данные есть, был рендеринг-баг
  • #1737 confidence: RU-имя сервиса вместо «Компонент вкладывающий сервис»
  • #1738 pipeline self-exclusion (проект не считает сам себя)
  • #1739 PDF-500: причина больше не скрыта + format=pdf в forecast export + font fallback
  • #1740 gate↔recommendation: gate_caveat при «нельзя МКД» (противоречие явное)

Verify: py_compile, tsc 0, ruff, pytest 95 passed. Остальной фидбек (#1741-1746) — ждёт продуктовых решений по UX/scope.

Closes #1736
Closes #1737
Closes #1738
Closes #1739
Closes #1740

Боевой фидбек Anton по analyze (cad 66:41:0702048:27) → 5 дефектов исправлено. - **#1736** точки подключения на карте (MiniMap проброс, был только legacy) — verified live: данные есть, был рендеринг-баг - **#1737** confidence: RU-имя сервиса вместо «Компонент вкладывающий сервис» - **#1738** pipeline self-exclusion (проект не считает сам себя) - **#1739** PDF-500: причина больше не скрыта + format=pdf в forecast export + font fallback - **#1740** gate↔recommendation: gate_caveat при «нельзя МКД» (противоречие явное) Verify: py_compile, tsc 0, ruff, pytest 95 passed. Остальной фидбек (#1741-1746) — ждёт продуктовых решений по UX/scope. Closes #1736 Closes #1737 Closes #1738 Closes #1739 Closes #1740
bot-backend added 1 commit 2026-06-18 06:47:26 +00:00
fix(site-finder): 5 дефектов из боевого фидбека analyze (#1736 #1737 #1738 #1739 #1740)
Some checks failed
CI / changes (push) Successful in 9s
Details
CI / changes (pull_request) Successful in 6s
Details
CI / frontend-tests (push) Failing after 1m50s
Details
CI / frontend-tests (pull_request) Failing after 1m48s
Details
CI / openapi-codegen-check (pull_request) Failing after 2m39s
Details
CI / openapi-codegen-check (push) Failing after 2m46s
Details
CI / backend-tests (pull_request) Successful in 9m25s
Details
CI / backend-tests (push) Successful in 9m30s
Details
b1c0ea1268 
- #1736 MiniMap: проброс useConnectionPoints → точки подключения на карте analyze (были только в /legacy)
- #1737 confidence: пронесено имя сервиса → RU-ярлык (Рынок/Будущее предложение/…) вместо «Компонент вкладывающий сервис»
- #1738 pipeline: self-exclusion субъекта (ST_DWithin 80м) — проект не считает сам себя будущим конкурентом
- #1739 PDF: snapshot_pdf обёрнут в try/except+logger.exception (причина 500 видна) + format=pdf в forecast export + font_url fallback
- #1740 gate↔recommendation: при can_build_mkd=False — gate_caveat на обоих рекомендаторах (противоречие явное, не молчит)

Verify: py_compile 5/5, tsc 0, ruff clean, pytest confidence/forecast 95 passed.

Closes #1736
Closes #1737
Closes #1738
Closes #1739
Closes #1740
bot-backend added 1 commit 2026-06-18 07:00:30 +00:00
chore(frontend): regenerate api-types.ts for forecast pdf export (#1739)
Some checks failed
CI / changes (pull_request) Successful in 8s
Details
CI / changes (push) Successful in 10s
Details
CI / frontend-tests (pull_request) Failing after 1m47s
Details
CI / frontend-tests (push) Failing after 1m55s
Details
CI / openapi-codegen-check (pull_request) Successful in 3m11s
Details
CI / openapi-codegen-check (push) Successful in 3m1s
Details
CI / backend-tests (pull_request) Successful in 10m29s
Details
CI / backend-tests (push) Successful in 10m41s
Details
e7342d9f98 
#1748 added format=pdf to the forecast export endpoint but didn't regenerate
the frontend OpenAPI types, failing CI openapi-codegen-check. Regenerated via
the CI recipe (app.openapi() dump -> openapi-typescript -> prettier).
bot-backend added 1 commit 2026-06-18 07:03:51 +00:00
test(site-finder): wrap MiniMap test render in QueryClientProvider (#1736)
All checks were successful
CI / changes (pull_request) Successful in 11s
Details
CI / changes (push) Successful in 15s
Details
CI / frontend-tests (push) Successful in 1m31s
Details
CI / frontend-tests (pull_request) Successful in 1m17s
Details
CI / openapi-codegen-check (push) Successful in 2m28s
Details
CI / openapi-codegen-check (pull_request) Successful in 2m37s
Details
CI / backend-tests (push) Successful in 10m32s
Details
CI / backend-tests (pull_request) Successful in 10m34s
Details
0f9babb7ff 
#1736 added useConnectionPoints (useQuery) to MiniMap, but MiniMap.test.tsx
rendered without a QueryClient -> 'No QueryClient set' (2 failing tests in CI
frontend-tests). Wrap renders in a QueryClientProvider (retry:false).
bot-backend added 3 commits 2026-06-18 07:06:07 +00:00
Merge remote fix/sf-feedback-batch (#1736 minimap test) into local
All checks were successful
CI / changes (pull_request) Successful in 8s
Details
CI / frontend-tests (pull_request) Successful in 1m39s
Details
CI / openapi-codegen-check (pull_request) Successful in 3m30s
Details
CI / backend-tests (pull_request) Successful in 9m35s
Details
3280859170
lekss361 merged commit 6214baf0c9 into main 2026-06-18 07:06:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1748
No description provided.
Delete branch "fix/sf-feedback-batch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?