fix(scrapers): narrow domrf Level-1 status badge-class regex (#1609 follow-up) #1704

Merged

lekss361 merged 1 commit from fix/domrf-badge-regex-narrow-1686 into main

2026-06-17 18:34:33 +00:00

lekss361 commented

2026-06-17 18:28:45 +00:00

Owner

Проблема (ревью #1686)

_STATUS_BADGE_CLS_RE = status|badge|tag|chip|label слишком широк — срабатывал на любой generic tag/chip/label.

Решение

(?<![a-z])status(?![a-z]) — требует токен status в CSS-классе. Реальные бейджи (status-badge, flat-status-tag, status-label) матчатся; generic элементы уходят в Level-2/3 каскад.

Verify

ruff clean; pytest -k domrf → 85 passed, 6 skipped (+тест: generic label/tag/chip/badge не берётся как статус).

## Проблема (ревью #1686) `_STATUS_BADGE_CLS_RE = status|badge|tag|chip|label` слишком широк — срабатывал на любой generic `tag`/`chip`/`label`. ## Решение `(?<![a-z])status(?![a-z])` — требует токен `status` в CSS-классе. Реальные бейджи (`status-badge`, `flat-status-tag`, `status-label`) матчатся; generic элементы уходят в Level-2/3 каскад. ## Verify `ruff` clean; `pytest -k domrf` → **85 passed, 6 skipped** (+тест: generic label/tag/chip/badge не берётся как статус).

lekss361 added 1 commit 2026-06-17 18:28:46 +00:00

fix(scrapers): narrow domrf Level-1 status badge-class regex (#1609 follow-up)

CI / changes (push) Successful in 8s

Details

CI / changes (pull_request) Has been cancelled

Details

CI / backend-tests (pull_request) Has been cancelled

Details

CI / frontend-tests (pull_request) Has been cancelled

Details

CI / openapi-codegen-check (pull_request) Has been cancelled

Details

CI / backend-tests (push) Has been cancelled

Details

CI / frontend-tests (push) Has been cancelled

Details

CI / openapi-codegen-check (push) Has been cancelled

Details

c3c89646ce

_STATUS_BADGE_CLS_RE was too broad: `status|badge|tag|chip|label` matched
generic UI elements (e.g. <span class="label">, <span class="chip">) that
are unrelated to the sale-status badge, risking picking the wrong block.

Narrowed to `(?<![a-z])status(?![a-z])` — requires the literal token
"status" as a hyphen-delimited component of the CSS class (matches
`status-badge`, `flat-status-tag`, `object-status` but not bare `label`,
`tag`, `chip`, `badge`).

Adds regression test: page with generic label/tag/chip/badge elements
containing "В продаже" must NOT activate Level-1; only the real
`status-badge` block ("Продана") should be returned → status=sold.