fix(tradein): trade-in PDF cover uses estimate.expires_at, not hardcoded +30d (#1530) #1676

Merged
lekss361 merged 1 commit from fix/pdf-expires-at-1530 into main 2026-06-17 17:45:04 +00:00
Owner

Проблема (#1530)

В trade_in_pdf.py:452 «Срок действия данных» = today + 30d хардкод, реальное поле estimate.expires_at игнорировалось.

Решение

Использовать estimate.expires_at.date(); defensive-fallback на today+30d если None (поле типизировано non-optional, но fallback в стиле других optional-полей экспортёра). Несвязанный period_months*30 (lookback сделок, :799) не тронут.

Verify

  • ruff clean, py_compile ok; pytest -k "pdf or exporter or cover"48 passed.

Closes #1530

## Проблема (#1530) В `trade_in_pdf.py:452` «Срок действия данных» = `today + 30d` хардкод, реальное поле `estimate.expires_at` игнорировалось. ## Решение Использовать `estimate.expires_at.date()`; defensive-fallback на `today+30d` если None (поле типизировано non-optional, но fallback в стиле других optional-полей экспортёра). Несвязанный `period_months*30` (lookback сделок, :799) не тронут. ## Verify - `ruff` clean, `py_compile` ok; `pytest -k "pdf or exporter or cover"` → **48 passed**. Closes #1530
lekss361 added 1 commit 2026-06-17 17:31:08 +00:00
fix(tradein): trade-in PDF cover uses estimate.expires_at, not hardcoded +30d (#1530)
All checks were successful
CI / changes (push) Successful in 10s
CI / changes (pull_request) Successful in 6s
CI / backend-tests (push) Has been skipped
CI / frontend-tests (push) Has been skipped
CI / openapi-codegen-check (push) Has been skipped
CI / backend-tests (pull_request) Has been skipped
CI / frontend-tests (pull_request) Has been skipped
CI / openapi-codegen-check (pull_request) Has been skipped
f8ea119d22
lekss361 merged commit 3dcddae647 into main 2026-06-17 17:45:04 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1676
No description provided.