lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

feat(velocity): migrate D2 sales source → objective_corpus_room_month (#156) #157

Closed
lekss361 wants to merge 4 commits from feat/migrate-velocity-to-objective-data into main
pull from: feat/migrate-velocity-to-objective-data
merge into: lekss361:main
Conversation 1 Commits 4 Files changed 6 +289 -265

4 commits

Author SHA1 Message Date
lekss361
c29e6ab661 fix(velocity): cross-stack contract + NULL safety per pre-push review 
3 pre-push code-reviewer findings fixed:

1. TS union extended ('objective'|'sale_graph'|'rosreestr_fallback')
   + UI conditions handle both objective и sale_graph как valid sources.
2. COALESCE(deals_total_vol_m2, deals_total_count * 45.0) — NULL safety
   for DKP-only rows (vol_m2 nullable, count > 0).
3. room_bucket parking filter — verified false positive (все 5 buckets
   apartments: студия/1/2/3/4+).

Refs: PR #157 pre-push code-reviewer
 2026-05-15 09:20:51 +03:00
lekss361
fa6bbafa3f feat(velocity): migrate D2 sales source from stale sale_graph to objective_corpus_room_month 
Closes #156
 2026-05-15 09:16:03 +03:00
lekss361
37fd4b5a8e fix(velocity): SAVEPOINT per query (not db.rollback) — correct SQLAlchemy 2.0 pattern 
Per PR #155 bot review — мой db.rollback() в catches был НЕПРАВИЛЬНЫЙ.

Session.rollback() = ENTIRE outer tx (не savepoint). Outer SAVEPOINT context
становится orphaned → InvalidRequestError на __exit__.

Correct fix: wrap каждый db.execute в свой with db.begin_nested():
- Failure → __exit__ propagates exception → SAVEPOINT rolls back
- Outer tx остаётся clean
- velocity returns None gracefully → caller продолжает

Все 3 SQL queries в velocity.py теперь SAVEPOINT-wrapped:
- compute_velocity: competitor_query
- compute_velocity: sales_rows query
- _get_ekb_median: median query

db.rollback() removed из всех 3 catches.

Refs: PR #155 bot review
 2026-05-15 08:49:28 +03:00
lekss361
c3cafefb1a fix(site-finder): db.rollback() в velocity catches + SAVEPOINT zoning/success_rec 
velocity.py 3 internal try/except возвращали None БЕЗ db.rollback(). PR #154
SAVEPOINT не помог — exception не propagates из velocity. Postgres tx
aborted внутри, cascade InFailedSqlTransaction на следующих queries.

Fix:
- velocity.py: db.rollback() в 3 catch блоках
- parcels.py: SAVEPOINT обёртки для zoning + success_recommendation

Refs: user reports 2026-05-15 cascade 500
 2026-05-15 08:41:13 +03:00