lekss361/gendesign

fix(#945): indicator-aware macro region + debt data-quality doc #1041

Merged

bot-backend merged 1 commit from fix/945-macro-region-debt into main

2026-06-04 06:49:49 +00:00

bot-backend commented

2026-06-04 06:49:45 +00:00

Collaborator

#945 FOLLOW-UP (Leha: not a bug).

PART1 (code): macro reader get_macro_series/get_latest_macro defaulted region='rf' but mortgage_* live under 'sverdl' -> latent footgun (only caller passes region explicitly, no active leak). region now str|None -> _canonical_region (mortgage->sverdl, else->rf); explicit region wins. Region-binding tests. 159 pass.

PART2 (documented, NOT code-fixed): mortgage_debt/overdue empty because cbr_mortgage_series.period holds value-garbage ('10054588.0') for Debt rows -- upstream CBR-XLSX scraper corruption (domrf.db, imported verbatim), not an ingest bug. 123_macro_indicator.sql correctly skips unparseable periods. Needs separate scraper re-ingest. Refs #945

#945 FOLLOW-UP (Leha: not a bug). PART1 (code): macro reader get_macro_series/get_latest_macro defaulted region='rf' but mortgage_* live under 'sverdl' -> latent footgun (only caller passes region explicitly, no active leak). region now str|None -> _canonical_region (mortgage->sverdl, else->rf); explicit region wins. Region-binding tests. 159 pass. PART2 (documented, NOT code-fixed): mortgage_debt/overdue empty because cbr_mortgage_series.period holds value-garbage ('10054588.0') for Debt rows -- upstream CBR-XLSX scraper corruption (domrf.db, imported verbatim), not an ingest bug. 123_macro_indicator.sql correctly skips unparseable periods. Needs separate scraper re-ingest. Refs #945

bot-backend added 1 commit 2026-06-04 06:49:45 +00:00

fix(#945 ): indicator-aware default region in macro reader + document debt data-quality

Deploy / changes (push) Successful in 6s

Details

Deploy / build-frontend (push) Has been skipped

Details

Deploy / build-backend (push) Successful in 2m53s

Details

Deploy / build-worker (push) Successful in 3m19s

Details

Deploy / deploy (push) Successful in 1m10s

Details

FOLLOW-UP (Leha: not a bug, follow-up).

get_macro_series / get_latest_macro defaulted region='rf', but CBR mortgage_*
series live under 'sverdl' in macro_indicator (key_rate under 'rf'). Only caller
passes region explicitly so no active leak, but a future caller omitting region
would silently get None — latent footgun. region now str|None; when None →
_canonical_region (mortgage set sourced from _CBR_SERIES_MAP, single source of
truth). Explicit region always wins → existing callers unchanged. Region-binding
tests added. 159 tests pass.

Documented (NOT code-fixed — upstream data-quality): mortgage_debt /
mortgage_overdue stay empty in macro_indicator because cbr_mortgage_series.period
holds value-like garbage (e.g. '10054588.0') for the Debt series — corruption
from the upstream CBR-XLSX scraper that built domrf.db (imported verbatim by
44_import_anton_db.py), NOT an ingest bug. 123_macro_indicator.sql correctly
skips unparseable periods. Needs a separate scraper re-ingest (idempotent
backfill once period is valid). Refs #945

bot-backend merged commit 3945d54e3b into main

2026-06-04 06:49:49 +00:00

bot-backend deleted branch fix/945-macro-region-debt

2026-06-04 06:49:49 +00:00

Sign in to join this conversation.

No reviewers

No labels

Fable 5 ревью

GG-форсайт

needs-discussion

status/needs-analysis

status/needs-fix

week ревью 1

вторичка

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1041

No description provided.