lekss361/gendesign

fix(exporters): real SiteFinderReport keys in PDF/Excel (#989 #991) #1037

Merged

bot-backend merged 1 commit from fix/989-991-exporter-keys into main

2026-06-04 05:56:58 +00:00

bot-backend commented

2026-06-04 05:56:54 +00:00

Collaborator

REOPENED #989 (PDF) + #991 (Excel) — exporters read non-existent dict keys -> demand/supply/scenario columns silently rendered "—". Tests passed only because fixtures were STALE (hand-typed the same wrong keys = fixture agreed with buggy exporter).

future_market: demand/supply -> projected_demand_units/projected_supply_units
scenarios: drop non-existent per-scenario overall; show primary-horizon deficit_index (scoring.overall was NOT broken — Leha conflated the two)
Excel #991: add missing future_supply + confidence.factors sections; +future_supply in PDF for parity
tests rebuilt from real as_dict() + contract-key regression guards (reintroducing old keys -> test fails). 28 passed.

REOPENED #989 (PDF) + #991 (Excel) — exporters read non-existent dict keys -> demand/supply/scenario columns silently rendered "—". Tests passed only because fixtures were STALE (hand-typed the same wrong keys = fixture agreed with buggy exporter). - future_market: demand/supply -> projected_demand_units/projected_supply_units - scenarios: drop non-existent per-scenario overall; show primary-horizon deficit_index (scoring.overall was NOT broken — Leha conflated the two) - Excel #991: add missing future_supply + confidence.factors sections; +future_supply in PDF for parity - tests rebuilt from real as_dict() + contract-key regression guards (reintroducing old keys -> test fails). 28 passed. Refs #989 #991

bot-backend added 1 commit 2026-06-04 05:56:55 +00:00

fix(exporters): read real SiteFinderReport keys in PDF/Excel (#989 , #991 )

Deploy / changes (push) Successful in 5s

Details

Deploy / build-frontend (push) Has been skipped

Details

Deploy / build-backend (push) Successful in 1m18s

Details

Deploy / build-worker (push) Successful in 6m57s

Details

Deploy / deploy (push) Successful in 1m19s

Details

REOPENED. PDF + Excel exporters read non-existent dict keys, so demand/supply/
scenario columns silently rendered "—". Tests passed only because the fixtures
were stale (hand-typed the same wrong keys → fixture agreed with buggy exporter).

- future_market: demand/supply → projected_demand_units/projected_supply_units
- scenarios: drop non-existent per-scenario "overall"; show primary-horizon
  deficit_index from ScenarioForecast.forecasts (scoring.overall was NOT broken)
- Excel #991: add missing future_supply (index + breakdown) + confidence.factors
  sections; add future_supply to PDF for parity
- tests: rebuild forecast/scenario fixtures from real DemandSupplyForecast /
  ScenarioForecast as_dict(); contract-key regression guards fail on key-drift
  (verified: reintroducing old keys fails the new tests). 28 passed.

Refs #989 #991

bot-backend merged commit 33d1a63bc8 into main

2026-06-04 05:56:58 +00:00

bot-backend deleted branch fix/989-991-exporter-keys

2026-06-04 05:56:59 +00:00

bot-backend referenced this pull request

2026-06-04 06:52:52 +00:00

[SF-v2 #955] 955-A3: Refactor exporters на SiteFinderReport + unified pdf.py #989

bot-backend referenced this pull request

2026-06-04 06:52:53 +00:00

[SF-v2 #955] 955-A5: Excel-экспортёр (real impl) #991

Sign in to join this conversation.

No reviewers

No labels

Fable 5 ревью

GG-форсайт

needs-discussion

status/needs-analysis

status/needs-fix

week ревью 1

вторичка

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1037

No description provided.