lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(tradein): persist scrape_runs.total_seen/new_count from sweep counters (#1926) #1928

Merged
bot-backend merged 1 commit from fix/1926-scrape-total-seen into main 2026-06-26 18:09:18 +00:00
Conversation 0 Commits 1 Files changed 2 +175 -10
bot-backend commented 2026-06-26 18:05:11 +00:00
Collaborator
Copy link

Root (audit #1871/#1926): city-sweep counters (yandex/avito/cian/domclick/newbuilding) писали lots_fetched/lots_inserted только в scrape_runs.counters jsonb; колонки total_seen/new_count (схема 015) не выставлялись → observability показывала total_seen=0 при реально сохранённых строках («observability врёт»).

Fix (Option A — одно место, все источники): helper _column_counts() в scrape_runs.py мапит lots_fetched→total_seen, lots_inserted→new_count (явные ключи приоритетнее). update_heartbeat/mark_done/mark_failed/mark_banned SET-ят обе колонки через COALESCE(CAST(:x AS int), col) (psycopg v3) — отсутствие ключа сохраняет старое значение. Покрывает yandex+avito+cian (+domclick/newbuilding), т.к. все пайплайны идут через эти финализаторы. Без миграции (колонки уже есть).

Tests: +6 в test_city_sweep.py; полный сьют 2419 passed, 0 failed (с 2 known-flaky deselect). ruff clean.

Refs #1926, #1871

**Root (audit #1871/#1926):** city-sweep counters (yandex/avito/cian/domclick/newbuilding) писали `lots_fetched`/`lots_inserted` только в `scrape_runs.counters` jsonb; колонки `total_seen`/`new_count` (схема 015) не выставлялись → observability показывала `total_seen=0` при реально сохранённых строках («observability врёт»). **Fix (Option A — одно место, все источники):** helper `_column_counts()` в `scrape_runs.py` мапит `lots_fetched`→`total_seen`, `lots_inserted`→`new_count` (явные ключи приоритетнее). `update_heartbeat`/`mark_done`/`mark_failed`/`mark_banned` SET-ят обе колонки через `COALESCE(CAST(:x AS int), col)` (psycopg v3) — отсутствие ключа сохраняет старое значение. Покрывает yandex+avito+cian (+domclick/newbuilding), т.к. все пайплайны идут через эти финализаторы. Без миграции (колонки уже есть). **Tests:** +6 в `test_city_sweep.py`; **полный сьют 2419 passed, 0 failed** (с 2 known-flaky deselect). ruff clean. Refs #1926, #1871
bot-backend added 1 commit 2026-06-26 18:05:12 +00:00
fix(tradein): persist scrape_runs.total_seen/new_count columns from sweep counters (#1926)
All checks were successful
CI / changes (pull_request) Successful in 6s
Details
CI / frontend-tests (pull_request) Has been skipped
Details
CI / backend-tests (pull_request) Has been skipped
Details
CI / openapi-codegen-check (pull_request) Has been skipped
Details
f87b6ada4c 
Root: city-sweep counters (yandex/avito/cian/domclick/newbuilding) wrote
lots_fetched/lots_inserted only into scrape_runs.counters jsonb; the dedicated
columns total_seen/new_count (schema 015) were never SET, so admin/observability
reported total_seen=0 despite real rows saved (audit #1871/#1926).

Fix (Option A): single-place extraction in scrape_runs.py via _column_counts()
maps counters lots_fetched->total_seen and lots_inserted->new_count (with
explicit total_seen/new_count keys taking priority). update_heartbeat, mark_done,
mark_failed and mark_banned now SET both columns with COALESCE(CAST(:x AS int),
col) so a missing key preserves the existing value. Covers all sweep sources at
once since every pipeline routes counters through these finalizers.
bot-backend merged commit 89d05bbfec into main 2026-06-26 18:09:18 +00:00
bot-backend deleted branch fix/1926-scrape-total-seen 2026-06-26 18:09:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1928
No description provided.
Delete branch "fix/1926-scrape-total-seen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?