5 commits

Author	SHA1	Message	Date
bot-backend	8fdcd8df62	fix(tradein/geocoder): word-boundary EKB short-circuit + gate suggest() + gazetteer (#11) ... Deep-review fast-follows on the non-EKB city gate: 1. Word-boundary the "екатеринбург" short-circuit in _names_non_ekb_city (new _EKATERINBURG_RE = \bекатеринбург\b, .search() instead of substring `in`). A bare-substring check matched "Екатеринбургское шоссе" (a real street in satellite towns like Pervouralsk) as if it named EKB, wrongly keeping EKB-only local tiers on for a non-EKB address. Still returns False for the existing homonym false-positive test case (word boundary is satisfied there — "екатеринбург" appears as a standalone token). 2. Gate suggest()'s Tier 1 (same root cause as geocode()): the EKB-only cadastral matchers _cadastral_house_match / _cadastral_forward_sync ran unconditionally, so a non-EKB oblast autocomplete query could surface an EKB building via street+house collision. Gated behind `not _names_non_ekb_city(query)`, mirroring geocode()'s use_local_ekb. External suggest tiers (DaData/Yandex/Nominatim) untouched — still the path for non-EKB autocomplete. 3. Extended SVERDLOVSK_OBLAST_CITIES with unambiguous, deal-heavy oblast cities: алапаевск, сухой лог, кушва, красноуральск, карпинск, нижняя тура, верхний тагил, нижние серги. Deliberately did NOT add "лесной" (reviewer flagged as reviewer-optional, left to judgment): DB check (ekb_geoportal_buildings) confirms a real EKB street named exactly "Лесной" (3 buildings) — an exact whole-word collision indistinguishable from ЗАТО Лесной by word-boundary matching alone (unlike "Серова"/"Серов", which are different word forms). Adding it would misclassify a bare EKB address ("Лесной, 5", no "Екатеринбург" mention) as non-EKB. Tests: word-boundary EKB regression test, suggest() gating test, two new gazetteer entries (Верхняя Пышма multi-word, Сухой Лог).	2026-07-13 00:06:19 +03:00
bot-backend	2ef3e42da1	fix(tradein/geocoder): explicit Екатеринбург wins over oblast-city homonym (#11) ... Prod-cache verification (deep-review) found 3 false-positives: EKB addresses that literally contain "екатеринбург" but also happen to contain a homonym of another oblast city inside a neighborhood/posyolok name — ЖК "Заречный" and пос. Сысерть, both administratively inside Ekaterinburg, not the ZATO Zarechny / town Sysert they share a name with. These were gated off the EKB-only local tiers; if Nominatim were momentarily down, a real EKB address would return None — a latent regression not present before this PR. Add an explicit-city short-circuit at the top of _names_non_ekb_city: if the normalized address contains "екатеринбург", return False immediately (EKB tiers stay on). Cannot affect the true-positive (non-EKB) cases, which never contain "екатеринбург".	2026-07-12 23:50:49 +03:00
bot-backend	720cee2c8e	fix(tradein/geocoder): gate EKB-local tiers for non-EKB oblast addresses (#11) ... geocode() ran EKB-only local tiers (2a _geoportal_house_match on ekb_geoportal_buildings, 2c _cadastral_house_match, 2d _cadastral_forward_sync — all strictly EKB or EKB-dominated) BEFORE the already oblast-aware external providers (Yandex/Nominatim via OBLAST66_BBOX + region cross-check, shipped in c0cbdc2f). _parse_street_house drops the city, so any non-EKB oblast street+house that collides with an EKB building (e.g. "проспект Ленина 1" exists in both Nizhny Tagil and EKB) short-circuited to EKB coordinates. Add _names_non_ekb_city() — reuses the existing SVERDLOVSK_OBLAST_CITIES gazetteer (minus Ekaterinburg) and word-boundary matching from _has_oblast_marker/_DISTRICT_PREFIXES — to detect when an address explicitly names a different oblast city. Gate tiers 2a/2c/2d behind `use_local_ekb = not _names_non_ekb_city(address)`; EKB/bare addresses keep the exact same code path (byte-identical ordering/logic, only additive gating). Non-EKB addresses fall straight through to Yandex/Nominatim, which already handle oblast-wide geocoding correctly. Verified gendesign_cad_buildings is 99.85% EKB-scoped (47043/47111 rows); ekb_geoportal_buildings is 100% EKB by construction — gating loses no meaningful local coverage for non-EKB cities. Follow-up (not in this PR): geocode_cache has rows poisoned by the old behavior (non-EKB addresses cached with EKB coordinates) — needs a purge.	2026-07-12 23:45:40 +03:00
bot-backend	c0cbdc2f99	fix(tradein/geocoder): раз-хардкод геокодера/DaData на всю Свердловскую обл. (region 66) ... Геокодер был жёстко EKB-bound и ВЫБРАСЫВАЛ корректные non-EKB геокоды (bbox-accept-фильтры) → блокировал оценку любого адреса области. Обобщено до region-66. - OBLAST66_BBOX + is_within_oblast66_bbox (superset EKB-tight, EKB не затронут); EKB Yandex Tier1/2 fast-path сохранён. - Все accept-фильтры (Yandex/Nominatim forward+suggest, geocode() accept+typo) → oblast-66. - City-prefix по word-boundary _has_oblast_marker (не substring): EKB-улицы 'Серова 27'/'Ирбитская 5' и др. больше не роняют 'Екатеринбург,'-префикс (был silent wrong-city баг). - Two-pass tie-break в accept-циклах: tight-EKB кандидат приоритетнее → EKB-результат идентичен прежнему. - Region cross-check (Nominatim address.state / Yandex AdministrativeAreaName) отсекает соседние области (Тюмень и др.); bbox-fallback когда region отсутствует. - DaData suggest: region-параметр (hard-filter), убран no-op restrict_value. - +26 тестов: OBLAST66 superset TIGHT, far-town accept, Тюмень reject, marker +/- (street-collision), DaData region body. Foundation для A2 (геокодинг non-EKB сделок) и live-оценки адресов области.	2026-07-12 18:33:05 +03:00
Light1YT	04550bc94f	fix(tradein): drop non-EKB avito detail coords on ingest (audit #1871 P2) ... avito_detail.parse_detail_html писал data-map-lat/lon прямо в listings UPDATE COALESCE без bbox-валидации — в отличие от geocoder.py, который фильтрует везде. Итог: 406 active avito-листингов с координатами Питер/Тюмень/Уфа просочились в ЕКБ-датасет (ложные аналоги через Tier A address-match оценщика). Prod-verified 2026-06-23. - geocoder: DRY-хелпер is_within_ekb_bbox(lat, lon, bbox) + именованные EKB_BBOX_TIGHT (geocoder-фильтр, числа не изменены) и EKB_BBOX_WIDE (ingest-guard); 2 inline tight-проверки → хелпер (поведение identical). - avito_detail: после извлечения lat/lon → reset None + logger.warning если вне wide-bbox; листинг падает в geocode-cron путь (COALESCE NULL не затирает прежнее хорошее значение). - tests: bbox-хелпер (ЕКБ True, Питер/Тюмень/Уфа False, inclusive, WIDE⊇TIGHT инвариант) + parse_detail_html guard end-to-end. WIDE строго содержит TIGHT — guard физически не режет ничего, что geocoder сам бы пропустил. NULL lat (14935, geocode backlog) — отдельная проблема, не в scope. One-time cleanup существующих 406 — отдельно (database-expert, prod data mutation). Refs #1871	2026-06-23 14:33:10 +05:00