bot-backend
9e5086890f
Some checks failed
CI / changes (pull_request) Has been cancelled
CI / backend-tests (pull_request) Has been cancelled
CI / frontend-tests (pull_request) Has been cancelled
CI / openapi-codegen-check (pull_request) Has been cancelled
CI / changes (push) Successful in 8s
CI / backend-tests (push) Has been cancelled
CI / frontend-tests (push) Has been cancelled
CI / openapi-codegen-check (push) Has been cancelled
sat_factor = 1 + ((sold_pct-50)/100)*0.30 was computed in 09_macro_and_trend.py, written to district_economics.sat_factor, and fetched in server.py and 10_score_v2.py — but never multiplied into any score. The live market sub-score uses a separate sat_score = min(100, sold_pct*100/70) directly, so sat_factor was dead code that would double-count absorption if ever wired in. - 09_macro_and_trend.py: remove sat_factor computation, ALTER TABLE column, UPDATE binding, and debug print column - 10_score_v2.py: remove sat_factor from SELECT and unpacking - server.py: remove sat_factor variable assignment and from macro_factors response - static/index.html: remove sat_factor documentation row - data/sql/162_drop_district_economics_sat_factor.sql: DROP COLUMN IF EXISTS
12 lines
554 B
PL/PgSQL
12 lines
554 B
PL/PgSQL
-- Remove dead column district_economics.sat_factor (#1509).
|
|
--
|
|
-- sat_factor = 1 + ((sold_pct - 50) / 100) * 0.30 was computed in 09_macro_and_trend.py
|
|
-- and written here, but was never read by any scoring logic (10_score_v2.py, server.py).
|
|
-- The live market sub-score uses sat_score = min(100, sold_pct * 100 / 70) directly,
|
|
-- so sat_factor double-counts absorption without being applied anywhere.
|
|
-- All code references removed in the same commit as this migration.
|
|
BEGIN;
|
|
|
|
ALTER TABLE district_economics DROP COLUMN IF EXISTS sat_factor;
|
|
|
|
COMMIT;
|