lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(nspd-geo): replace f-string bulk INSERT with parametrized execute (SQL injection fix) #123

Merged
lekss361 merged 1 commit from fix/nspd-geo-sql-injection into main 2026-05-14 20:29:12 +00:00
Conversation 3 Commits 1 Files changed 1 +9 -8
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
backend/app/workers/tasks/nspd_geo.py
View file

@ -295,17 +295,18 @@ def enqueue_geo_job(
}, },
).scalar_one() ).scalar_one()
# Bulk INSERT targets # Bulk INSERT targets — parametrized to prevent SQL injection
if cad_nums_with_thematic: if cad_nums_with_thematic:
values = ",".join(
f"({job_id}, '{c.replace(chr(39), chr(39)*2)}', {t}, 'pending')"
for c, t in cad_nums_with_thematic
)
db.execute( db.execute(
text( text(
f"INSERT INTO nspd_geo_targets (job_id, cad_num, thematic_id, status) " "INSERT INTO nspd_geo_targets (job_id, cad_num, thematic_id, status) "
f"VALUES {values} ON CONFLICT (job_id, cad_num, thematic_id) DO NOTHING" "VALUES (:job_id, :cad_num, :thematic_id, 'pending') "
) "ON CONFLICT (job_id, cad_num, thematic_id) DO NOTHING"
),
[
{"job_id": job_id, "cad_num": c, "thematic_id": t}
for c, t in cad_nums_with_thematic
],
) )
db.commit() db.commit()
return int(job_id) return int(job_id)