chore(claude-rules): promote 3 deferred feedback rules from memory #496

Merged

lekss361 merged 1 commit from chore/promote-memory-deferred into main

2026-05-24 09:01:28 +00:00

lekss361 commented

2026-05-24 08:56:34 +00:00

Owner

Summary

Follow-up to #495. MEMORY.md sweep (2026-05-24) identified 3 stable feedback rules that were ready to promote into path-scoped rule files but had to wait while #495 was open (rules were being restructured there). Now integrating.

Changes

.claude/rules/frontend.md — new section "package.json + lockfile sync (CRITICAL — deploy aborts on mismatch)".
Mandatory npm install --legacy-peer-deps after any frontend/package.json edit + commit both files. Mismatch → npm ci fails in Dockerfile → docker compose --abort-on-container-exit → full deploy rollback (frontend + backend). Reference incident: PR #345 hotfix after PR #344.
.claude/rules/deploy.md — new section "Post-deploy verification (MANDATORY)" at top.
After every successful merge + deploy on main → spawn qa-tester subagent with playwright smoke. Catches prod TypeErrors / 4xx / overlay bugs in 2 min before user finds them. Reference incident: PR #346 (multiple bugs user found manually).
.claude/rules/backend.md — new section "Web probing (scrapers — use playwright MCP, not curl)".
For URL params / selectors / anti-bot exploration → mcp__playwright__* first (real browser dodges captcha). Curl/curl_cffi only for actual production scraping after param set is known. Reference incident: 2026-05-23 Yandex SERP reverse-engineering captcha on 2nd iteration.

Source files deleted from auto-memory

Promoted entries are no longer needed in ~/.claude/projects/<repo>/memory/:

feedback_npm_install_when_changing_package_json.md
feedback_qa_tester_after_each_deploy.md
feedback_use_playwright_not_curl_for_probing.md

Removed from MEMORY.md index, added to "Removed (promoted 2026-05-24)" table.

Test plan

After merge: trigger any .tsx edit → confirm frontend.md auto-loads with new section
Next backend/app/scrapers/** work → confirm web probing rule visible
Next deploy success → confirm I spawn qa-tester per rule

Notes

Pure config / rules. No app code touched. Auto-deploy won't trigger (only .claude/rules/** changed).

## Summary Follow-up to #495. MEMORY.md sweep (2026-05-24) identified 3 stable feedback rules that were ready to promote into path-scoped rule files but had to wait while #495 was open (rules were being restructured there). Now integrating. ## Changes - **`.claude/rules/frontend.md`** — new section **"package.json + lockfile sync (CRITICAL — deploy aborts on mismatch)"**. Mandatory `npm install --legacy-peer-deps` after any `frontend/package.json` edit + commit both files. Mismatch → `npm ci` fails in Dockerfile → `docker compose --abort-on-container-exit` → full deploy rollback (frontend + backend). Reference incident: PR #345 hotfix after PR #344. - **`.claude/rules/deploy.md`** — new section **"Post-deploy verification (MANDATORY)"** at top. After every successful merge + deploy on main → spawn `qa-tester` subagent with playwright smoke. Catches prod TypeErrors / 4xx / overlay bugs in 2 min before user finds them. Reference incident: PR #346 (multiple bugs user found manually). - **`.claude/rules/backend.md`** — new section **"Web probing (scrapers — use playwright MCP, not curl)"**. For URL params / selectors / anti-bot exploration → `mcp__playwright__*` first (real browser dodges captcha). Curl/curl_cffi only for actual production scraping after param set is known. Reference incident: 2026-05-23 Yandex SERP reverse-engineering captcha on 2nd iteration. ## Source files deleted from auto-memory Promoted entries are no longer needed in `~/.claude/projects/<repo>/memory/`: - `feedback_npm_install_when_changing_package_json.md` - `feedback_qa_tester_after_each_deploy.md` - `feedback_use_playwright_not_curl_for_probing.md` Removed from MEMORY.md index, added to "Removed (promoted 2026-05-24)" table. ## Test plan - [ ] After merge: trigger any `.tsx` edit → confirm `frontend.md` auto-loads with new section - [ ] Next `backend/app/scrapers/**` work → confirm web probing rule visible - [ ] Next deploy success → confirm I spawn qa-tester per rule ## Notes Pure config / rules. No app code touched. Auto-deploy won't trigger (only `.claude/rules/**` changed).

lekss361 added 1 commit 2026-05-24 08:56:34 +00:00

chore(claude-rules): promote 3 deferred feedback rules from memory 8b7696ad15

Follow-up to #495 — integrating 3 stable feedback rules into path-scoped
rule files (per MEMORY.md sweep 2026-05-24).

- frontend.md: + package.json + lockfile sync section
  (mismatch -> npm ci fails -> deploy aborts; ref PR #345)
- deploy.md: + Post-deploy verification section
  (spawn qa-tester smoke after every deploy success on main)
- backend.md: + Web probing section
  (playwright MCP for probing scrapers, curl/curl_cffi for actual scraping)

Source feedback files deleted from ~/.claude/projects/.../memory/
and added to Removed table in MEMORY.md.

lekss361 merged commit 643064ee0c into main

2026-05-24 09:01:28 +00:00

lekss361 referenced this pull request from a commit

2026-05-24 09:01:30 +00:00

chore(claude-rules): promote 3 deferred feedback rules from memory (#496)

lekss361 commented

2026-05-24 09:01:51 +00:00

Author

Owner

Merged via deep-code-reviewer — verdict APPROVE.

Review checks:

Diff matches description: +46/-0 across 3 files (backend.md +16, deploy.md +14, frontend.md +16)
Frontmatter paths: preserved on all 3 rule files
New H2 sections inserted between existing sections (no overlap/regression to neighbouring sections)
Section content actionable + linked to concrete incidents (PR #344/#345 for lockfile, PR #346 for qa-tester, 2026-05-23 Yandex SERP for playwright probing)
No app code, no deploy trigger (paths only .claude/rules/**), no security/runtime implications

Squash merge commit: 643064ee0cbf928c9cc14bda89e312e22dcd5b2d.

Merged via deep-code-reviewer — verdict APPROVE. **Review checks:** - Diff matches description: +46/-0 across 3 files (backend.md +16, deploy.md +14, frontend.md +16) - Frontmatter `paths:` preserved on all 3 rule files - New H2 sections inserted between existing sections (no overlap/regression to neighbouring sections) - Section content actionable + linked to concrete incidents (PR #344/#345 for lockfile, PR #346 for qa-tester, 2026-05-23 Yandex SERP for playwright probing) - No app code, no deploy trigger (paths only `.claude/rules/**`), no security/runtime implications Squash merge commit: `643064ee0cbf928c9cc14bda89e312e22dcd5b2d`.