prefix in Cian page Link (PR #486 follow-up) #489

Merged

lekss361 merged 1 commit from fix/tradein-cian-double-prefix into main

2026-05-23 15:56:01 +00:00

lekss361 commented

2026-05-23 15:53:52 +00:00

Owner

Issue

User clicked callout link на /scrapers/cian page → URL became https://gendsgn.ru/trade-in/trade-in/scrapers/cian-cookies → 404 Not Found + client-side exception "Application error: a client-side exception has occurred".

Root cause

tradein-mvp/frontend/next.config has basePath: "/trade-in". Next.js automatically prepends basePath to internal <Link href="..."> paths.

Hardcoding /trade-in/ в href doubles the prefix:

Before	Effective URL
`<Link href="/trade-in/scrapers/cian-cookies">`	`/trade-in/trade-in/scrapers/cian-cookies` ❌ 404
`<Link href="/scrapers/cian-cookies">`	`/trade-in/scrapers/cian-cookies` ✅

Fix

tradein-mvp/frontend/src/app/scrapers/cian/page.tsx — 2 occurrences:

Line ~170 callout link: /trade-in/scrapers/cian-cookies → /scrapers/cian-cookies
Line ~297 callout link: /trade-in/scrapers/cian-cookies → /scrapers/cian-cookies

Push verify

LOCAL == REMOTE = fbbe382b

Refs

PR #486 (Cian admin page — introduced the bug)
Next.js basePath docs: internal links resolved relative to basePath

Test plan

TS check clean
Push verified
Post-deploy: open /trade-in/scrapers/cian → click callout link → loads /trade-in/scrapers/cian-cookies без 404

## Issue User clicked callout link на `/scrapers/cian` page → URL became `https://gendsgn.ru/trade-in/trade-in/scrapers/cian-cookies` → **404 Not Found** + client-side exception "Application error: a client-side exception has occurred". ## Root cause `tradein-mvp/frontend/next.config` has `basePath: "/trade-in"`. Next.js automatically prepends basePath to internal `<Link href="...">` paths. Hardcoding `/trade-in/` в href doubles the prefix: | Before | Effective URL | |---|---| | `<Link href="/trade-in/scrapers/cian-cookies">` | `/trade-in/trade-in/scrapers/cian-cookies` ❌ 404 | | `<Link href="/scrapers/cian-cookies">` | `/trade-in/scrapers/cian-cookies` ✅ | ## Fix `tradein-mvp/frontend/src/app/scrapers/cian/page.tsx` — 2 occurrences: - Line ~170 callout link: `/trade-in/scrapers/cian-cookies` → `/scrapers/cian-cookies` - Line ~297 callout link: `/trade-in/scrapers/cian-cookies` → `/scrapers/cian-cookies` ## Push verify LOCAL == REMOTE = `fbbe382b` ## Refs - PR #486 (Cian admin page — introduced the bug) - Next.js basePath docs: internal links resolved relative to basePath ## Test plan - [x] TS check clean - [x] Push verified - [ ] Post-deploy: open `/trade-in/scrapers/cian` → click callout link → loads `/trade-in/scrapers/cian-cookies` без 404

lekss361 added 1 commit 2026-05-23 15:53:53 +00:00

fix(tradein-ui): remove double /trade-in/ prefix in internal Links (basePath auto-prepends) fbbe382b97

Next.js basePath=/trade-in automatically prepends to all internal href paths.
Hardcoding /trade-in/ in <Link> resulted in /trade-in/trade-in/... -> 404.
Affected: /scrapers/cian page callout link to cookies upload (2 occurrences).