feat(trade-in): TI-2 PDF export 4-page + frontend enable button #319

Merged

lekss361 merged 1 commit from feat/ti-2-pdf into main

2026-05-17 17:16:49 +00:00

lekss361 commented

2026-05-17 17:08:02 +00:00

Owner

Summary

Wave C финал issue #314 TradeIn MVP. Backend WeasyPrint 4-page PDF + frontend кнопка «Скачать PDF» enabled.

Files

backend/app/services/exporters/trade_in_pdf.py (NEW, ~250 lines) — generate_trade_in_pdf(estimate, input_snapshot) -> bytes. 4-page WeasyPrint HTML+CSS: Cover / Listings / Actual Deals / Trade-in Cost stub. Pattern mirrors layout_tz_pdf.py (Cyrillic-ready).
backend/app/api/v1/trade_in.py (EXTENDED) — new GET /api/v1/trade-in/estimate/{estimate_id}/pdf endpoint:
- Reads DB row с full input snapshot
- 404 если estimate not found
- 410 если TTL expired (24h)
- Returns application/pdf + Content-Disposition: attachment
- SQL: CAST(:id AS uuid) — psycopg v3 compliant
frontend/src/components/trade-in/EstimateResult.tsx (MODIFIED) — disabled <button> + tooltip «Coming in TI-2» replaced with active <a href download> → ${NEXT_PUBLIC_API_URL}/api/v1/trade-in/estimate/${estimate.estimate_id}/pdf
Vault fixes/Fix_TradeIn_MVP_TI2_PDF_May17.md — design notes + pitfalls

4 PDF pages

Cover — header + address + input summary + hero price + confidence badge
Listings — top 7-10 analogs table (фото / адрес / площадь / цена / экспозиция)
Actual deals — реальные сделки last 12 mo
Trade-in cost — placeholder explainer (Phase 2 full breakdown)

Compliance

✅ psycopg v3 CAST(:id AS uuid) (no ::type)
✅ ruff + ruff-format + prettier pre-commit pass
✅ TS strict — frontend tsc clean

Test plan

POST /api/v1/trade-in/estimate → take estimate_id
GET /api/v1/trade-in/estimate/{id}/pdf → downloads 4-page PDF
PDF opens в Adobe Reader / Chrome без errors
Cyrillic renders correctly
Frontend /trade-in → submit form → click «Скачать PDF» → file downloads
Expired estimate (>24h) returns 410

Closes #314 (Wave C — TI-2/4 last sub-tasks before TI-5 smoke). Depends on TI-1 #316, TI-3 #317 (both merged).

## Summary Wave C финал issue #314 TradeIn MVP. Backend WeasyPrint 4-page PDF + frontend кнопка «Скачать PDF» enabled. ## Files - `backend/app/services/exporters/trade_in_pdf.py` (NEW, ~250 lines) — `generate_trade_in_pdf(estimate, input_snapshot) -> bytes`. 4-page WeasyPrint HTML+CSS: Cover / Listings / Actual Deals / Trade-in Cost stub. Pattern mirrors `layout_tz_pdf.py` (Cyrillic-ready). - `backend/app/api/v1/trade_in.py` (EXTENDED) — new `GET /api/v1/trade-in/estimate/{estimate_id}/pdf` endpoint: - Reads DB row с full input snapshot - 404 если estimate not found - 410 если TTL expired (24h) - Returns `application/pdf` + `Content-Disposition: attachment` - SQL: `CAST(:id AS uuid)` — psycopg v3 compliant - `frontend/src/components/trade-in/EstimateResult.tsx` (MODIFIED) — disabled `<button>` + tooltip «Coming in TI-2» replaced with active `<a href download>` → `${NEXT_PUBLIC_API_URL}/api/v1/trade-in/estimate/${estimate.estimate_id}/pdf` - Vault `fixes/Fix_TradeIn_MVP_TI2_PDF_May17.md` — design notes + pitfalls ## 4 PDF pages 1. **Cover** — header + address + input summary + hero price + confidence badge 2. **Listings** — top 7-10 analogs table (фото / адрес / площадь / цена / экспозиция) 3. **Actual deals** — реальные сделки last 12 mo 4. **Trade-in cost** — placeholder explainer (Phase 2 full breakdown) ## Compliance - ✅ psycopg v3 `CAST(:id AS uuid)` (no `::type`) - ✅ ruff + ruff-format + prettier pre-commit pass - ✅ TS strict — frontend tsc clean ## Test plan - [ ] `POST /api/v1/trade-in/estimate` → take `estimate_id` - [ ] `GET /api/v1/trade-in/estimate/{id}/pdf` → downloads 4-page PDF - [ ] PDF opens в Adobe Reader / Chrome без errors - [ ] Cyrillic renders correctly - [ ] Frontend `/trade-in` → submit form → click «Скачать PDF» → file downloads - [ ] Expired estimate (>24h) returns 410 Closes #314 (Wave C — TI-2/4 last sub-tasks before TI-5 smoke). Depends on TI-1 #316, TI-3 #317 (both merged).

lekss361 added 1 commit 2026-05-17 17:08:03 +00:00

feat(trade-in): TI-2 PDF export + frontend enable button 7ea4f262cd

- Add backend/app/services/exporters/trade_in_pdf.py: 4-page WeasyPrint PDF
  (Cover / Listings / Deals / Trade-in cost stub) following layout_tz_pdf.py pattern
- Extend trade_in.py: GET /api/v1/trade-in/estimate/{id}/pdf endpoint
  (404 not found, 410 expired TTL, application/pdf attachment)
- Enable EstimateResult.tsx PDF button: replace disabled button with active
  anchor tag using NEXT_PUBLIC_API_URL + estimate_id

Closes #314 (TI-2 + TI-4 sub-tasks)

lekss361 commented

2026-05-17 17:16:41 +00:00

Author

Owner

Deep Code Review — verdict ✅ APPROVE

Files: 3 (P1: 2 backend, P2: 1 frontend) · +529/-42 · ~12 min

Critical checks passed

✅ psycopg v3: CAST(:id AS uuid) used everywhere, no :x::type (backend/app/api/v1/trade_in.py:330)
✅ HTML escape: _html.escape() applied to input_snapshot.address (trade_in_pdf.py:130) and lot.address in analog rows (trade_in_pdf.py:54). Numeric fields (area_m2: float, rooms: int, floor: int) are typed → no injection vector
✅ No SSRF via WeasyPrint: photo_url is NOT embedded into PDF — analog table has only 6 columns (address / area / rooms / floor / price / date), images skipped. No remote URL fetched during PDF render
✅ TTL handling: explicit if row.expires_at.replace(tzinfo=UTC) < datetime.now(tz=UTC): 410 (trade_in.py:347) — intentionally differs from TI-1 get_estimate (which mixed 404+expired into single 404). 410 Gone is correct semantic for expired-but-existed-once
✅ Frontend safe URL: estimate.estimate_id is TS-typed UUID from AggregatedEstimate interface, interpolated after fixed prefix ${NEXT_PUBLIC_API_URL ?? ""}/api/v1/trade-in/estimate/ — no javascript: injection possible
✅ Content-Disposition filename: f'attachment; filename="trade-in-{estimate_id}.pdf"' — estimate_id is UUID path-param (FastAPI validates), no header injection
✅ Pattern consistency: mirrors layout_tz_pdf.py (same _html.escape, same WeasyPrint flow, same Cyrillic-ready font stack Helvetica, Arial)
✅ Schema alignment: all AnalogLot fields used (listing_date, days_on_market, floor, total_floors, address, area_m2, rooms, price_rub) match backend/app/schemas/trade_in.py
✅ DB columns alignment: SELECT lists exactly 19 columns that exist in data/sql/115_trade_in_estimates.sql (TI-1 schema)
✅ Auth pattern: consistent with sibling get_estimate and estimate endpoints — no auth, UUID is unguessable

Low / nits (non-blocking, future polish)

row.expires_at.replace(tzinfo=UTC) (trade_in.py:347) is redundant — timestamptz already returns TZ-aware UTC datetime. No-op, safe but verbose.
PDF endpoint is expensive (WeasyPrint cold-render ~200-500ms). Theoretical DoS if UUID leaks. Out of scope for MVP — add rate-limit middleware in Phase 2 if needed.
No tests for new endpoint — consistent with TI-1/TI-3 MVP pattern (per PR body). Not blocking, but TI-5 smoke task should cover end-to-end.
lot.rooms if lot.rooms else 'С' (trade_in_pdf.py:58) — rooms == 0 (студия) renders as "С" which is intentional (studio shorthand). OK.

Cross-file impact

Endpoint GET /trade-in/estimate/{id}/pdf — new, no existing callers affected
Frontend <a href download> replaces disabled <button> cleanly — no other consumers of the old disabled element
generate_trade_in_pdf import added correctly to module top (TI-1 had stray from fastapi import HTTPException inside function — this PR cleans that up by moving to top-level imports ✅)
No DB schema change, no migration impact

Risk / blast radius

Risk: Low
Reversibility: Easy revert (additive feature, no DB change, no schema breaking)
Merge window: anytime

Merging via deep-code-reviewer (any-scope policy 2026-05-16).

## Deep Code Review — verdict ✅ APPROVE **Files**: 3 (P1: 2 backend, P2: 1 frontend) · **+529/-42** · ~12 min ### Critical checks passed - ✅ **psycopg v3**: `CAST(:id AS uuid)` used everywhere, no `:x::type` (`backend/app/api/v1/trade_in.py:330`) - ✅ **HTML escape**: `_html.escape()` applied to `input_snapshot.address` (`trade_in_pdf.py:130`) and `lot.address` in analog rows (`trade_in_pdf.py:54`). Numeric fields (`area_m2: float`, `rooms: int`, `floor: int`) are typed → no injection vector - ✅ **No SSRF via WeasyPrint**: `photo_url` is NOT embedded into PDF — analog table has only 6 columns (address / area / rooms / floor / price / date), images skipped. No remote URL fetched during PDF render - ✅ **TTL handling**: explicit `if row.expires_at.replace(tzinfo=UTC) < datetime.now(tz=UTC): 410` (`trade_in.py:347`) — intentionally differs from TI-1 `get_estimate` (which mixed 404+expired into single 404). 410 Gone is correct semantic for expired-but-existed-once - ✅ **Frontend safe URL**: `estimate.estimate_id` is TS-typed `UUID` from `AggregatedEstimate` interface, interpolated after fixed prefix `${NEXT_PUBLIC_API_URL ?? ""}/api/v1/trade-in/estimate/` — no `javascript:` injection possible - ✅ **Content-Disposition filename**: `f'attachment; filename="trade-in-{estimate_id}.pdf"'` — estimate_id is `UUID` path-param (FastAPI validates), no header injection - ✅ **Pattern consistency**: mirrors `layout_tz_pdf.py` (same `_html.escape`, same WeasyPrint flow, same Cyrillic-ready font stack `Helvetica, Arial`) - ✅ **Schema alignment**: all `AnalogLot` fields used (`listing_date`, `days_on_market`, `floor`, `total_floors`, `address`, `area_m2`, `rooms`, `price_rub`) match `backend/app/schemas/trade_in.py` - ✅ **DB columns alignment**: SELECT lists exactly 19 columns that exist in `data/sql/115_trade_in_estimates.sql` (TI-1 schema) - ✅ **Auth pattern**: consistent with sibling `get_estimate` and `estimate` endpoints — no auth, UUID is unguessable ### Low / nits (non-blocking, future polish) - `row.expires_at.replace(tzinfo=UTC)` (`trade_in.py:347`) is redundant — `timestamptz` already returns TZ-aware UTC datetime. No-op, safe but verbose. - PDF endpoint is expensive (WeasyPrint cold-render ~200-500ms). Theoretical DoS if UUID leaks. **Out of scope for MVP** — add rate-limit middleware in Phase 2 if needed. - No tests for new endpoint — consistent with TI-1/TI-3 MVP pattern (per PR body). Not blocking, but TI-5 smoke task should cover end-to-end. - `lot.rooms if lot.rooms else 'С'` (`trade_in_pdf.py:58`) — `rooms == 0` (студия) renders as "С" which is intentional (studio shorthand). OK. ### Cross-file impact - Endpoint `GET /trade-in/estimate/{id}/pdf` — new, no existing callers affected - Frontend `<a href download>` replaces disabled `<button>` cleanly — no other consumers of the old disabled element - `generate_trade_in_pdf` import added correctly to module top (TI-1 had stray `from fastapi import HTTPException` inside function — this PR cleans that up by moving to top-level imports ✅) - No DB schema change, no migration impact ### Risk / blast radius - **Risk**: Low - **Reversibility**: Easy revert (additive feature, no DB change, no schema breaking) - **Merge window**: anytime Merging via deep-code-reviewer (any-scope policy 2026-05-16).