lekss361/gendesign

fix(tradein/location-coef): re-center coefficient band so a strong central location ~= 1.0 (LOW audit R2 #7a) #2509

Merged

bot-backend merged 1 commit from fix/tradein-location-coef-recenter into main

2026-07-12 22:12:11 +00:00

bot-backend commented

2026-07-12 22:09:55 +00:00

Collaborator

LOW audit round-2 #7a. The location coefficient normalized against an unreachable all-POI-at-0m maximum, so even a strong central EKB address scored ~25-30/100 -> coef ~0.975-0.98, reading as if location always slightly reduces value. Normalize against a realistic reference distance (100m) instead: strong-central 0.978 -> 1.0065, weak stays 0.95. Informational only (estimator does not use it); uncalibrated-heuristic caveat kept. 16 tests pass. Pairs with #2508 (drawer informational label). Metro under-weighting is a separate cross-repo freshness-filter issue (gendesign OSM view) documented as gated follow-up.

LOW audit round-2 #7a. The location coefficient normalized against an unreachable all-POI-at-0m maximum, so even a strong central EKB address scored ~25-30/100 -> coef ~0.975-0.98, reading as if location always slightly reduces value. Normalize against a realistic reference distance (100m) instead: strong-central 0.978 -> 1.0065, weak stays 0.95. Informational only (estimator does not use it); uncalibrated-heuristic caveat kept. 16 tests pass. Pairs with #2508 (drawer informational label). Metro under-weighting is a separate cross-repo freshness-filter issue (gendesign OSM view) documented as gated follow-up.

bot-backend added 1 commit 2026-07-12 22:09:56 +00:00

fix(tradein/location-coef): re-center coefficient band so a strong central location ~= 1.0

CI / changes (pull_request) Successful in 9s

Details

CI / openapi-codegen-check (pull_request) Has been skipped

Details

CI Trade-In / changes (pull_request) Successful in 11s

Details

CI Trade-In / frontend-checks (pull_request) Has been skipped

Details

CI / backend-tests (pull_request) Has been skipped

Details

CI / frontend-tests (pull_request) Has been skipped

Details

CI Trade-In / backend-tests (pull_request) Successful in 52s

Details

The normalization used an unreachable all-POI-at-0m maximum, compressing real
scores into ~0.975-0.98 so every address read as "location reduces value".
Normalize against a realistic reference distance instead; strong central ~ 1.0,
poor locations stay below. Informational only (estimator does not use it).
Kept the uncalibrated-heuristic caveat. LOW audit R2 (#7a).

bot-backend merged commit 5e73b35206 into main

2026-07-12 22:12:11 +00:00

bot-backend deleted branch fix/tradein-location-coef-recenter

2026-07-12 22:12:12 +00:00

bot-backend referenced this pull request from a commit

2026-07-12 22:12:12 +00:00

fix(tradein/location-coef): re-center coefficient band so a strong central location ~= 1.0 (LOW audit R2 #7a) (#2509)

Sign in to join this conversation.

No reviewers

No labels

Fable 5 ревью

GG-форсайт

needs-discussion

status/needs-analysis

status/needs-fix

week ревью 1

вторичка

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#2509

No description provided.