lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(tradein): cian fetch_newbuilding через BrowserFetcher (camoufox) — initialState под анти-ботом (#972) #1540

Merged
lekss361 merged 1 commit from fix/cian-newbuilding-browser-fetch into main 2026-06-15 15:44:42 +00:00
Conversation 0 Commits 1 Files changed 2 +126 -120
bot-backend commented 2026-06-15 15:20:01 +00:00
Collaborator
Copy link

Summary

  • fetch_newbuilding в cian_newbuilding.py теперь тянет HTML страницы ЖК через BrowserFetcher (camoufox/tradein-browser) вместо curl_cffi AsyncSession
  • Причина: curl_cffi получает zhk-*.cian.ru страницу без initialState под анти-ботом Cian; tradein-browser верифицирован живым (1.17 MB HTML, initialState присутствует)
  • session= параметр сохранён как опциональный для backward-compat вызывающих (backfill вызывает await fetch_newbuilding(zhk_url) без session — работает без изменений)
  • resolve_cian_zhk_url_via_search (curl_cffi SERP) не тронут

Test plan

  • ruff check — All checks passed
  • ruff-format — применил pre-commit hook
  • 21/21 тестов в tests/test_cian_newbuilding.py прошли (включая 3 новых async-теста с mock на BrowserFetcher.fetch)
  • tests/tasks/test_newbuilding_enrich_backfill.py — pre-existing collection failure (psycopg2 vs psycopg v3 в локальном venv), не связан с нашими изменениями

Refs #972

## Summary - `fetch_newbuilding` в `cian_newbuilding.py` теперь тянет HTML страницы ЖК через `BrowserFetcher` (camoufox/tradein-browser) вместо `curl_cffi AsyncSession` - Причина: curl_cffi получает zhk-*.cian.ru страницу без `initialState` под анти-ботом Cian; tradein-browser верифицирован живым (1.17 MB HTML, initialState присутствует) - `session=` параметр сохранён как опциональный для backward-compat вызывающих (backfill вызывает `await fetch_newbuilding(zhk_url)` без session — работает без изменений) - `resolve_cian_zhk_url_via_search` (curl_cffi SERP) не тронут ## Test plan - [x] `ruff check` — All checks passed - [x] `ruff-format` — применил pre-commit hook - [x] 21/21 тестов в `tests/test_cian_newbuilding.py` прошли (включая 3 новых async-теста с mock на `BrowserFetcher.fetch`) - [x] `tests/tasks/test_newbuilding_enrich_backfill.py` — pre-existing collection failure (psycopg2 vs psycopg v3 в локальном venv), не связан с нашими изменениями Refs #972
bot-backend added 1 commit 2026-06-15 15:20:02 +00:00
fix(tradein): cian fetch_newbuilding через BrowserFetcher (camoufox) — initialState под анти-ботом (#972)
All checks were successful
CI / changes (push) Successful in 7s
Details
CI / backend-tests (push) Has been skipped
Details
CI / frontend-tests (push) Has been skipped
Details
CI / openapi-codegen-check (push) Has been skipped
Details
CI / changes (pull_request) Successful in 6s
Details
CI / frontend-tests (pull_request) Has been skipped
Details
CI / openapi-codegen-check (pull_request) Has been skipped
Details
CI / backend-tests (pull_request) Has been skipped
Details
480fbba3ca 
curl_cffi получает zhk-*.cian.ru без initialState; tradein-browser (camoufox) тянет
страницу с 1.17MB initialState. Заменяем транспорт только для page-fetch;
session= param сохранён для backward-compat вызывающих. resolve_cian_zhk_url_via_search
остаётся на curl_cffi SERP. Тесты: 21 passed.
lekss361 merged commit b3e7a9f9fa into main 2026-06-15 15:44:42 +00:00
lekss361 deleted branch fix/cian-newbuilding-browser-fetch 2026-06-15 15:44:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin UI / internal tools / pipeline tracker

  
analytics

Аналитика данных / matching

  
auth

Authentication / authorization / multi-tenancy

  
automation

Автоматизация / cron / scheduler

  
bug

Something isn't working

  
business

Коммерческая воронка / пилоты / pipeline / реестр ПО

  
chore

Operational housekeeping

  
ci

Forgejo Actions / build pipeline

  
compliance

152-ФЗ / реестр ПО / legal / TOS

  
data

Data sources, parsers, ETL

  
data-moat

Уникальные данные — sales tracker, CRM aggregation

  
docs

README / runbooks / onboarding

  
duplicate

This issue or pull request already exists

  
dx

Developer experience / build speed

  
enhancement

New feature or request

  
Fable 5 ревью

Находки полного мульти-агентного ревью (Claude Fable 5, 2026-06-09)

  
feedback/max

Feedback from Max (Senior partner)

  
generative

Generative Design — concept generation engine

  
GG-форсайт

Новое ТЗ от Ген Геныча (июнь 2026): Site Finder v2 — ИИ-прогноз продуктовой стратегии девелопера. Актуальный приоритет.

  
needs-discussion

Pending team sync / decision

  
needs-human

Human review/decision required

  
observability

Monitoring / metrics / logs / Sentry / Uptime

  
pause-bots

Kill-switch — all autonomous bots pause

  
performance

Latency / throughput / DB query tuning

  
priority/p0

Critical / production-blocker

  
priority/p1

High priority

  
priority/p2

Normal priority

  
priority/p3

Низкий приоритет (follow-up, tech-debt)

  
scope/backend

Backend Python — FastAPI, Celery, scrapers

  
scope/db

DB migrations, indexes, SQL

  
scope/devops

docker-compose, Caddy, workflows

  
scope/frontend

Frontend — Next.js, React, TypeScript

  
scope/qa

Tests, smoke, Playwright

  
scrapers

Скрапперы (Avito/Cian/Yandex/Rosreestr)

  
security

Security audit / secrets / vulnerabilities

  
site-finder

Site Finder scoring quality & data layer

  
stage/1

Stage 1: Generative MVP (нед 2-7)

  
stage/2

Stage 2: Site Finder MVP (нед 8-12)

  
status/blocked

Blocked — needs human intervention

  
status/done

Closed, completed

  
status/needs-analysis

Raw/fuzzy task filed by human — auto-analyst подхватывает: code-archeology + декомпозиция в actionable scope/* + status/ready (или split на под-issues)

  
status/needs-fix

Reviewer/QA вернул worker на доработку — worker сам чинит свой PR (fixup), НЕ требует human (в отличие от status/blocked)

  
status/qa

PR merged, awaiting smoke test

  
status/ready

Ready for pickup by worker bot

  
status/review

PR open, awaiting code review

  
status/wip

Work in progress (worker claimed)

  
tech-debt

Технический долг

  
tradein

Trade-In MVP проект

  
ux

User experience / responsive / conversion

  
week ревью 1

Week review 1 — находки multi-agent аудита проекта (2026-06-14)

  
wontfix

This will not be worked on

  
вторичка

Trade-In Estimator — проект оценки вторичного жилья

  
ИРД

Исходно-разрешительная документация — слой ограничений участка для analyze-таблицы

No labels
admin
analytics
auth
automation
bug
business
chore
ci
compliance
data
data-moat
docs
duplicate
dx
enhancement
Fable 5 ревью
feedback/max
generative
GG-форсайт
needs-discussion
needs-human
observability
pause-bots
performance
priority/p0
priority/p1
priority/p2
priority/p3
scope/backend
scope/db
scope/devops
scope/frontend
scope/qa
scrapers
security
site-finder
stage/1
stage/2
status/blocked
status/done
status/needs-analysis
status/needs-fix
status/qa
status/ready
status/review
status/wip
tech-debt
tradein
ux
week ревью 1
wontfix
вторичка
ИРД
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lekss361/gendesign#1540
No description provided.
Delete branch "fix/cian-newbuilding-browser-fetch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?