♻️ refactor: frontend DRY — SectionLabel + EmptyState + adminStyles.ts #129

New issue

Closed

opened 2026-05-14 20:31:36 +00:00 by lekss361 · 0 comments

lekss361 commented

2026-05-14 20:31:36 +00:00

(Migrated from github.com)

Per audit batch #127 P2 hygiene + feedback_sequential_prs hot zone.

Duplications found

<SectionLabel> — 5-line inline-style div (fontSize: 12, fontWeight: 600, textTransform: uppercase) повторяется 8+ раз в OverviewTab.tsx / LandTab.tsx / MarketTab.tsx
<EmptyState> — 4-line center text (color: #9ca3af, padding: 24px 0, textAlign: center) скопирован identically в LandTab.tsx:109, MarketTab.tsx:77, EnvironmentTab.tsx:521
adminStyles.ts — cardStyle, th, td, labelStyle, inputStyle redefined в 4 admin pages (scrape/page.tsx, scrape/all/page.tsx, leads/page.tsx, BulkGeoPanel.tsx)

Acceptance

frontend/src/components/ui/SectionLabel.tsx + replace all 8+ usages
frontend/src/components/ui/EmptyState.tsx + replace 3 usages
frontend/src/lib/adminStyles.ts + replace 4 admin pages
tsc 0 errors, lint 0 warnings
Visual regression NOT (style values одинаковые)

Refs: #127

Per audit batch #127 P2 hygiene + `feedback_sequential_prs` hot zone. ## Duplications found 1. **`<SectionLabel>`** — 5-line inline-style div (`fontSize: 12, fontWeight: 600, textTransform: uppercase`) повторяется 8+ раз в `OverviewTab.tsx` / `LandTab.tsx` / `MarketTab.tsx` 2. **`<EmptyState>`** — 4-line center text (`color: #9ca3af, padding: 24px 0, textAlign: center`) скопирован identically в `LandTab.tsx:109`, `MarketTab.tsx:77`, `EnvironmentTab.tsx:521` 3. **`adminStyles.ts`** — `cardStyle`, `th`, `td`, `labelStyle`, `inputStyle` redefined в 4 admin pages (`scrape/page.tsx`, `scrape/all/page.tsx`, `leads/page.tsx`, `BulkGeoPanel.tsx`) ## Acceptance - [ ] `frontend/src/components/ui/SectionLabel.tsx` + replace all 8+ usages - [ ] `frontend/src/components/ui/EmptyState.tsx` + replace 3 usages - [ ] `frontend/src/lib/adminStyles.ts` + replace 4 admin pages - [ ] tsc 0 errors, lint 0 warnings - [ ] Visual regression NOT (style values одинаковые) Refs: #127