3 commits

Author	SHA1	Message	Date
Light1YT	b8f9213cd9	feat(tradein): persistent infra для backfill scripts ... 3 проблемы фиксятся: 1. tradein-mvp/backend/Dockerfile копировал только COPY app — scripts/ слетал при каждом deploy, требовал manual docker cp. 2. docker-compose.prod.yml без env_file — .env.runtime не читался контейнером, переменные приходили только через host env. 3. Env-var name mismatch: compose YANDEX_GEOCODER_KEY vs script YANDEX_GEOCODER_API_KEY — script всегда видел None. Изменения: - backend/Dockerfile: COPY scripts ./scripts в builder + runner stage - docker-compose.prod.yml: * env_file: ./backend/.env.runtime (required: false) — pattern из main backend (PR #585) * убран дубль `YANDEX_GEOCODER_API_KEY: ${...}` из environment: block — он бы overrideal env_file пустым значением. Reviewer nit applied inline. - pydantic Settings (app/core/config.py): rename yandex_geocoder_key → yandex_geocoder_api_key. Case-insensitive env binding автоматически подхватывает `YANDEX_GEOCODER_API_KEY` (no Field alias нужен). - All 5 call sites в app/services/geocoder.py обновлены. - app/tasks/geocode_missing.py docstring + test mock обновлены. - backend/scripts/README.md: canonical `docker exec` commands без manual `docker cp` workflow. - DEPLOY.md + .env.example обновлены с новым именем переменной. Verified: - pytest tests/test_backfill_house_coords.py + test_audit_address_mismatch.py + test_cadastral_reverse.py → 56 pass - docker compose -f docker-compose.prod.yml config → valid syntax - pydantic binding: YANDEX_GEOCODER_API_KEY=foo → settings.yandex_geocoder_api_key=='foo' - code-reviewer LGTM (nit applied inline) После merge — на VPS уже создан /opt/gendesign/tradein-mvp/backend/.env.runtime с YANDEX_GEOCODER_API_KEY (см. PR #591 deploy). deploy.yml triggers force-recreate из-за нового image hash → env_file pick up автоматически.	2026-05-27 11:59:14 +05:00
lekss361	94cf199276	feat(tradein): postgres_fdw live read of gendesign.cad_buildings (replaces snapshot) (#493) ... Replaces tradein.cad_buildings snapshot with live postgres_fdw foreign table reading gendesign.v_tradein_cad_buildings. Fixes /trade-in/api/v1/geocode/reverse 500 (Nominatim ban) and address_not_geocoded for cadastre addresses (e.g. Хохрякова 81). Security (deep-review fixes): - 100_tradein_fdw_role.sql: passwordless CREATE ROLE; password set by deploy.yml ALTER ROLE bootstrap reading GENDESIGN_FDW_PASSWORD from backend/.env.runtime (via psql :'pw' var → format %L — injection-safe). - core/fdw.py: regex whitelist [A-Za-z0-9_-]{32,256} on password, ValueError without echoing value, try/rollback on commit. - 060_postgres_fdw_extension.sql: connect_timeout='3' on FOREIGN SERVER + ALTER ADD/SET fallback. - geocoder.py: _cadastral_forward_sync / _cadastral_reverse_sync wrapped in asyncio.to_thread. - 100_*.sql: REVOKE ALL ON ALL TABLES/SEQUENCES/FUNCTIONS IN SCHEMA public; only GRANT SELECT on v_tradein_cad_buildings. - pg_user_mappings query handles PUBLIC mapping (usename IS NULL). Tests: 3 SQL-injection guards on ensure_fdw_user_mapping + rewritten cadastral suite.	2026-05-24 08:57:30 +00:00
lekss361	0efd2dca1d	feat(tradein): cadastral reverse geocode via main backend cad_buildings (#492)	2026-05-24 07:31:12 +00:00