lekss361/gendesign
1
0
Fork 0
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

fix(browser): null-guard pageError.location in playwright bundle (#915)

Browse source 
Avito pages emit uncaught JS errors without a location (ad / cross-origin
scripts); playwright 1.60.0's dispatcher reads pageError.location.url with no
null-guard (coreBundle.js ×2: BrowserContextDispatcher + trace event) →
TypeError 'Cannot read properties of undefined (reading url)' crashes the
node-driver protocol connection → 'Connection closed while reading from the
driver' / TargetClosedError → tradein-browser returns 500 and server.py does a
full browser relaunch. Proven on prod run_32: ~6/21 /fetch hit 500, each
forcing a ~5-10s relaunch and stalling the city-sweep.

playwright upgrade is impossible — camoufox 0.4.11 pins the matching
Firefox+juggler build. Patch the pinned bundle in-image:
pageError.location.{url,lineNumber,columnNumber} -> optional chaining (no-op
when location is present). Build asserts >=2 sites patched, failing loudly on a
future playwright bump.

Verified against the deployed bundle: 2 unguarded -> 2 guarded, 0 remaining,
node --check OK.

Refs #883, #901, #916
This commit is contained in:
bot-backend 2026-05-31 21:34:43 +03:00
parent 62d989b8a3
commit a6afb4ad2b
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
tradein-mvp/browser/Dockerfile
View file

@ -23,6 +23,28 @@ WORKDIR /app
# camoufox[geoip] тянет playwright как зависимость
RUN pip install --no-cache-dir "camoufox[geoip]" aiohttp
# ── #915: null-guard для pageError.location в playwright 1.60.0 ─────────────────
# Firefox/juggler-бэкенд иногда отдаёт uncaught JS-ошибку страницы (реклама /
# cross-origin скрипты на avito) БЕЗ поля location. playwright-диспетчер при
# доставке pageError-события читает `pageError.location.url` (coreBundle.js,
# 2 места: BrowserContextDispatcher + trace event) без null-guard →
# `TypeError: Cannot read properties of undefined (reading 'url')` ВНУТРИ
# event-хэндлера node-драйвера → рвёт protocol-соединение → "Connection closed
# while reading from the driver" / TargetClosedError → server.py отдаёт 500 и
# делает полный relaunch браузера (дорого, тормозит sweep). Недетерминированно:
# зависит от того, кинет ли конкретная загрузка locationless-ошибку.
# Апгрейд playwright невозможен — camoufox 0.4.11 pinned под конкретный
# Firefox+juggler. Чиним optional-chaining'ом прямо в pinned-бандле:
# `pageError.location.X` → `pageError.location?.X` (no-op когда location есть;
# отдаёт {url:undefined,...} когда нет → событие доставляется без краша).
# Сборка падает (exit 1) если паттерн не найден — сигнал что bump playwright
# сломал патч.
RUN PW_BUNDLE="$(python -c 'import os,playwright;print(os.path.join(os.path.dirname(playwright.__file__),"driver","package","lib","coreBundle.js"))')" \
&& sed -i -E 's/pageError\.location\.(url|lineNumber|columnNumber)/pageError.location?.\1/g' "$PW_BUNDLE" \
&& N="$(grep -cF 'pageError.location?.url' "$PW_BUNDLE")" \
&& echo "tradein-browser: patched pageError.location?.url sites: $N" \
&& [ "$N" -ge 2 ]
COPY server.py ./server.py
# camoufox fetch качает (а) Firefox-сборку и (б) GeoLite2 mmdb (geoip=True).